Explorar o código

[CE/SP] Remove non-production dependencies (#33949)

Some non-production dependencies were bundled in the CE and SP images:
- `lint` was pulled as production dependency by `eslint-plugin`. Moving to peer-dependency, which is the usual strategy, addresses the issue.
- Yarn cache wasn't purged. By adding `/usr/local/share/.cache/yarn` to the mounts we ensure it's also cleaned.

GitOrigin-RevId: f328592c8f8de7193295839578e239a975fe30aa
Miguel Serrano hai 2 meses
pai
achega
21902e7a55
Modificáronse 3 ficheiros con 9 adicións e 4 borrados
  1. 3 1
      libraries/eslint-plugin/package.json
  2. 3 1
      server-ce/Dockerfile
  3. 3 2
      yarn.lock

+ 3 - 1
libraries/eslint-plugin/package.json

@@ -5,12 +5,14 @@
   "license": "AGPL-3.0-only",
   "main": "index.js",
   "dependencies": {
-    "eslint": "^8.51.0",
     "lodash": "^4.18.1"
   },
   "devDependencies": {
     "@typescript-eslint/parser": "^8.50.0"
   },
+  "peerDependencies": {
+    "eslint": "^8.51.0"
+  },
   "scripts": {
     "test": "node rules.test.js"
   }

+ 3 - 1
server-ce/Dockerfile

@@ -25,6 +25,7 @@ ENV COREPACK_ENABLE_NETWORK=0
 # -------------------------
 RUN --mount=type=cache,target=/root/.cache \
     --mount=type=cache,target=/root/.yarn/berry/cache,id=server-ce-yarn-cache \
+    --mount=type=cache,target=/usr/local/share/.cache/yarn,id=server-ce-yarn-fallback-cache \
     --mount=type=tmpfs,target=/tmp node genScript install | bash
 
 # Add the actual source files
@@ -32,9 +33,10 @@ RUN --mount=type=cache,target=/root/.cache \
 COPY --parents libraries/ services/ tools/migrations/ /overleaf/
 RUN --mount=type=cache,target=/root/.cache \
     --mount=type=cache,target=/root/.yarn/berry/cache,id=server-ce-yarn-cache \
+    --mount=type=cache,target=/usr/local/share/.cache/yarn,id=server-ce-yarn-fallback-cache \
     --mount=type=cache,target=/overleaf/services/web/node_modules/.cache,id=server-ce-webpack-cache \
     --mount=type=tmpfs,target=/tmp \
-    YARN_CACHE_FOLDER=/tmp/.yarn-cache node genScript compile | bash
+    node genScript compile | bash
 
 # Copy runit service startup scripts to its location
 # --------------------------------------------------

+ 3 - 2
yarn.lock

@@ -6565,8 +6565,9 @@ __metadata:
   resolution: "@overleaf/eslint-plugin@workspace:libraries/eslint-plugin"
   dependencies:
     "@typescript-eslint/parser": "npm:^8.50.0"
-    eslint: "npm:^8.51.0"
     lodash: "npm:^4.18.1"
+  peerDependencies:
+    eslint: ^8.51.0
   languageName: unknown
   linkType: soft
 
@@ -17965,7 +17966,7 @@ __metadata:
   languageName: node
   linkType: hard
 
-"eslint@npm:^8.15.0, eslint@npm:^8.51.0, eslint@npm:^8.57.0":
+"eslint@npm:^8.15.0, eslint@npm:^8.57.0":
   version: 8.57.1
   resolution: "eslint@npm:8.57.1"
   dependencies: