Merge pull request #2789 from overleaf/as-fix-no-undef

Enable no-undef linting rule for all frontend files and fix errors

GitOrigin-RevId: bf9c789a381af982bdece55a2f518a2b610c9202

services/web/.eslintrc

@@ -103,10 +103,12 @@
         "_": true,
         "ace": true,
         "ga": true,
+        "Raven": true, // Backwards compat for Sentry reporting
         "sl_console": true,
         "sl_debugging": true,
         // Injected in layout.pug
-        "user_id": true
+        "user_id": true,
+        "ExposedSettings": true
       }
     }
   ]

services/web/frontend/js/analytics/AbTestingManager.js

@@ -1,7 +1,6 @@
 /* eslint-disable
     camelcase,
     max-len,
-    no-undef,
     no-unused-vars,
 */
 // TODO: This file was created by bulk-decaffeinate.

services/web/frontend/js/base.js

@@ -1,7 +1,8 @@
+/* global MathJax */
+
 /* eslint-disable
     camelcase,
     max-len,
-    no-undef,
     no-useless-escape,
 */
 // TODO: This file was created by bulk-decaffeinate.
@@ -17,7 +18,7 @@
 
 // Configure dynamically loaded assets (via webpack) to be downloaded from CDN
 // See: https://webpack.js.org/guides/public-path/#on-the-fly
-__webpack_public_path__ = window.baseAssetPath
+__webpack_public_path__ = window.baseAssetPath // eslint-disable-line no-undef
 
 define([
   './libraries',

services/web/frontend/js/components/inputSuggestions.js

@@ -1,7 +1,6 @@
 /* eslint-disable
     max-len,
     no-return-assign,
-    no-undef,
 */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.

services/web/frontend/js/directives/asyncForm.js

@@ -1,7 +1,6 @@
 /* eslint-disable
     max-len,
     no-return-assign,
-    no-undef,
     no-unused-vars,
 */
 // TODO: This file was created by bulk-decaffeinate.

services/web/frontend/js/directives/complexPassword.js

@@ -1,5 +1,6 @@
+/* global PassField */
+
 /* eslint-disable
-    no-undef,
     max-len
 */
 define(['../base', 'libs/passfield'], function(App) {

services/web/frontend/js/directives/creditCards.js

@@ -1,6 +1,5 @@
 /* eslint-disable
     max-len,
-    no-undef,
     no-useless-escape,
 */
 // TODO: This file was created by bulk-decaffeinate.
@@ -14,70 +13,70 @@
  * Full docs: https://github.com/decaffeinate/decaffeinate/blob/master/docs/suggestions.md
  */
 define(['../base'], function(App) {
-  App.factory('ccUtils', function() {
-    const defaultFormat = /(\d{1,4})/g
-    const defaultInputFormat = /(?:^|\s)(\d{4})$/
-
-    const cards = [
-      // Credit cards
-      {
-        type: 'visa',
-        patterns: [4],
-        format: defaultFormat,
-        length: [13, 16],
-        cvcLength: [3],
-        luhn: true
-      },
-      {
-        type: 'mastercard',
-        patterns: [51, 52, 53, 54, 55, 22, 23, 24, 25, 26, 27],
-        format: defaultFormat,
-        length: [16],
-        cvcLength: [3],
-        luhn: true
-      },
-      {
-        type: 'amex',
-        patterns: [34, 37],
-        format: /(\d{1,4})(\d{1,6})?(\d{1,5})?/,
-        length: [15],
-        cvcLength: [3, 4],
-        luhn: true
-      },
-      {
-        type: 'dinersclub',
-        patterns: [30, 36, 38, 39],
-        format: /(\d{1,4})(\d{1,6})?(\d{1,4})?/,
-        length: [14],
-        cvcLength: [3],
-        luhn: true
-      },
-      {
-        type: 'discover',
-        patterns: [60, 64, 65, 622],
-        format: defaultFormat,
-        length: [16],
-        cvcLength: [3],
-        luhn: true
-      },
-      {
-        type: 'unionpay',
-        patterns: [62, 88],
-        format: defaultFormat,
-        length: [16, 17, 18, 19],
-        cvcLength: [3],
-        luhn: false
-      },
-      {
-        type: 'jcb',
-        patterns: [35],
-        format: defaultFormat,
-        length: [16],
-        cvcLength: [3],
-        luhn: true
-      }
-    ]
+  const defaultFormat = /(\d{1,4})/g
+  const defaultInputFormat = /(?:^|\s)(\d{4})$/
+
+  const cards = [
+    // Credit cards
+    {
+      type: 'visa',
+      patterns: [4],
+      format: defaultFormat,
+      length: [13, 16],
+      cvcLength: [3],
+      luhn: true
+    },
+    {
+      type: 'mastercard',
+      patterns: [51, 52, 53, 54, 55, 22, 23, 24, 25, 26, 27],
+      format: defaultFormat,
+      length: [16],
+      cvcLength: [3],
+      luhn: true
+    },
+    {
+      type: 'amex',
+      patterns: [34, 37],
+      format: /(\d{1,4})(\d{1,6})?(\d{1,5})?/,
+      length: [15],
+      cvcLength: [3, 4],
+      luhn: true
+    },
+    {
+      type: 'dinersclub',
+      patterns: [30, 36, 38, 39],
+      format: /(\d{1,4})(\d{1,6})?(\d{1,4})?/,
+      length: [14],
+      cvcLength: [3],
+      luhn: true
+    },
+    {
+      type: 'discover',
+      patterns: [60, 64, 65, 622],
+      format: defaultFormat,
+      length: [16],
+      cvcLength: [3],
+      luhn: true
+    },
+    {
+      type: 'unionpay',
+      patterns: [62, 88],
+      format: defaultFormat,
+      length: [16, 17, 18, 19],
+      cvcLength: [3],
+      luhn: false
+    },
+    {
+      type: 'jcb',
+      patterns: [35],
+      format: defaultFormat,
+      length: [16],
+      cvcLength: [3],
+      luhn: true
+    }
+  ]
 
+  App.factory('ccUtils', function() {
     const cardFromNumber = function(num) {
       num = (num + '').replace(/\D/g, '')
       for (let card of Array.from(cards)) {

services/web/frontend/js/directives/equals.js

@@ -1,5 +1,4 @@
 /* eslint-disable
-    no-undef,
 */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.

services/web/frontend/js/directives/eventTracking.js

@@ -1,7 +1,6 @@
 /* eslint-disable
     camelcase,
     max-len,
-    no-undef,
 */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.

services/web/frontend/js/directives/expandableTextArea.js

@@ -1,5 +1,4 @@
 /* eslint-disable
-    no-undef,
 */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.

services/web/frontend/js/directives/fineUpload.js

@@ -1,5 +1,4 @@
 /* eslint-disable
-    no-undef,
 */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.

services/web/frontend/js/directives/focus.js

@@ -1,6 +1,5 @@
 /* eslint-disable
     no-return-assign,
-    no-undef,
 */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.

services/web/frontend/js/directives/maxHeight.js

@@ -1,5 +1,4 @@
 /* eslint-disable
-    no-undef,
 */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.

services/web/frontend/js/directives/onEnter.js

@@ -1,5 +1,4 @@
 /* eslint-disable
-    no-undef,
 */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.

services/web/frontend/js/directives/rightClick.js

@@ -1,5 +1,4 @@
 /* eslint-disable
-    no-undef,
 */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.

services/web/frontend/js/directives/scroll.js

@@ -1,7 +1,6 @@
 /* eslint-disable
     max-len,
     no-return-assign,
-    no-undef,
 */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.

services/web/frontend/js/directives/selectAll.js

@@ -1,7 +1,6 @@
 /* eslint-disable
     max-len,
     no-return-assign,
-    no-undef,
 */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.

services/web/frontend/js/directives/stopPropagation.js

@@ -1,6 +1,5 @@
 /* eslint-disable
     max-len,
-    no-undef,
 */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.

services/web/frontend/js/directives/videoPlayState.js

@@ -1,6 +1,5 @@
 /* eslint-disable
     max-len,
-    no-undef,
 */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.

services/web/frontend/js/filters/formatDate.js

@@ -1,5 +1,4 @@
 /* eslint-disable
-    no-undef,
 */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.

services/web/frontend/js/filters/wrapLongWords.js

@@ -1,7 +1,6 @@
 /* eslint-disable
     max-len,
     no-return-assign,
-    no-undef,
     no-unused-vars,
     no-useless-escape,
 */

services/web/frontend/js/ide.js

@@ -3,7 +3,6 @@
     max-len,
     no-cond-assign,
     no-return-assign,
-    no-undef,
     no-unused-vars,
     no-useless-escape,
 */

services/web/frontend/js/ide/SafariScrollPatcher.js

@@ -1,7 +1,6 @@
 /* eslint-disable
     max-len,
     no-return-assign,
-    no-undef,
     no-unused-vars,
 */
 // TODO: This file was created by bulk-decaffeinate.

services/web/frontend/js/ide/binary-files/BinaryFilesManager.js

@@ -1,6 +1,5 @@
 /* eslint-disable
     max-len,
-    no-undef,
     no-unused-vars,
 */
 // TODO: This file was created by bulk-decaffeinate.

services/web/frontend/js/ide/chat/controllers/ChatButtonController.js

@@ -1,7 +1,6 @@
 /* eslint-disable
     max-len,
     no-return-assign,
-    no-undef,
 */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.

services/web/frontend/js/ide/chat/controllers/ChatController.js

@@ -1,7 +1,6 @@
 /* eslint-disable
     max-len,
     no-return-assign,
-    no-undef,
 */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.

services/web/frontend/js/ide/chat/controllers/ChatMessageController.js

@@ -1,7 +1,6 @@
 /* eslint-disable
     max-len,
     no-return-assign,
-    no-undef,
 */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.

services/web/frontend/js/ide/chat/index.js

@@ -1,5 +1,4 @@
 /* eslint-disable
-    no-undef,
 */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.

services/web/frontend/js/ide/chat/services/chatMessages.js

@@ -1,7 +1,8 @@
+/* global Raven */
+
 /* eslint-disable
     max-len,
     no-return-assign,
-    no-undef,
     no-unused-vars,
 */
 // TODO: This file was created by bulk-decaffeinate.

services/web/frontend/js/ide/clone/controllers/CloneProjectController.js

@@ -1,6 +1,5 @@
 /* eslint-disable
     no-return-assign,
-    no-undef,
 */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.

services/web/frontend/js/ide/clone/controllers/CloneProjectModalController.js

@@ -1,7 +1,6 @@
 /* eslint-disable
     max-len,
     no-return-assign,
-    no-undef,
 */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.

services/web/frontend/js/ide/clone/index.js

@@ -1,5 +1,4 @@
 /* eslint-disable
-    no-undef,
 */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.

services/web/frontend/js/ide/cobranding/CobrandingDataService.js

@@ -2,7 +2,6 @@
     camelcase,
     max-len,
     no-return-assign,
-    no-undef,
 */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.

services/web/frontend/js/ide/colors/ColorManager.js

@@ -2,7 +2,6 @@
     camelcase,
     max-len,
     no-return-assign,
-    no-undef,
     no-unused-vars,
 */
 // TODO: This file was created by bulk-decaffeinate.
@@ -48,8 +47,10 @@ define(['crypto-js/md5'], function(CryptoJS) {
       return r + g + b < 3 * 128
     },
 
-    OWN_HUE: 200, // We will always appear as this color to ourselves
     ANONYMOUS_HUE: 100,
+    OWN_HUE: 200, // We will always appear as this color to ourselves
+    OWN_HUE_BLOCKED_SIZE: 20, // no other user should havea HUE in this range
+    TOTAL_HUES: 360, // actually 361, but 360 for legacy reasons
     getHueForUserId(user_id) {
       if (user_id == null || user_id === 'anonymous-user') {
         return this.ANONYMOUS_HUE
@@ -59,11 +60,18 @@ define(['crypto-js/md5'], function(CryptoJS) {
         return this.OWN_HUE
       }
 
-      hue = this.getHueForId(user_id)
-      // Avoid 20 degrees either side of the personal hue
-      if (hue > this.OWNER_HUE - 20) {
-        hue = hue + 40
+      let hue = this.getHueForId(user_id)
+
+      // if `hue` is within `OWN_HUE_BLOCKED_SIZE` degrees of the personal hue
+      // (`OWN_HUE`), shift `hue` to the end of available hues by adding
+      if (
+        hue > this.OWN_HUE - this.OWN_HUE_BLOCKED_SIZE &&
+        hue < this.OWN_HUE + this.OWN_HUE_BLOCKED_SIZE
+      ) {
+        hue = hue - this.OWN_HUE // `hue` now at 0 +/- `OWN_HUE_BLOCKED_SIZE`
+        hue = hue + this.TOTAL_HUES - this.OWN_HUE_BLOCKED_SIZE
       }
+
       return hue
     },
 
@@ -73,7 +81,9 @@ define(['crypto-js/md5'], function(CryptoJS) {
 
     getHueForId(id) {
       const hash = CryptoJS(id)
-      let hue = parseInt(hash.toString().slice(0, 8), 16) % 320
+      let hue =
+        parseInt(hash.toString().slice(0, 8), 16) %
+        (this.TOTAL_HUES - this.OWN_HUE_BLOCKED_SIZE * 2)
       return hue
     }
   })

services/web/frontend/js/ide/directives/SafePath.js

@@ -1,7 +1,6 @@
 /* eslint-disable
     max-len,
     no-return-assign,
-    no-undef,
 */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.

services/web/frontend/js/ide/directives/layout.js

@@ -1,7 +1,6 @@
 /* eslint-disable
     max-len,
     no-return-assign,
-    no-undef,
     no-useless-escape,
 */
 // TODO: This file was created by bulk-decaffeinate.

services/web/frontend/js/ide/directives/validFile.js

@@ -1,7 +1,6 @@
 /* eslint-disable
     max-len,
     no-return-assign,
-    no-undef,
 */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.

services/web/frontend/js/ide/editor/Document.js

@@ -2,7 +2,6 @@
     camelcase,
     handle-callback-err,
     max-len,
-    no-undef,
 */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.

services/web/frontend/js/ide/editor/EditorManager.js

@@ -3,7 +3,6 @@
     handle-callback-err,
     max-len,
     no-return-assign,
-    no-undef,
 */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.

services/web/frontend/js/ide/editor/EditorShareJsCodec.js

@@ -1,7 +1,6 @@
 /* eslint-disable
     max-len,
     no-return-assign,
-    no-undef,
 */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.

services/web/frontend/js/ide/editor/ShareJsDoc.js

@@ -1,7 +1,6 @@
 /* eslint-disable
     camelcase,
     max-len,
-    no-undef,
     no-unused-vars,
 */
 // TODO: This file was created by bulk-decaffeinate.
@@ -157,7 +156,7 @@ define(['../../utils/EventEmitter', 'libs/sharejs'], function(
 
       _processQueue() {
         if (this.queuedMessages.length > 0) {
-          nextAvailableVersion = this.queuedMessages[0].v
+          const nextAvailableVersion = this.queuedMessages[0].v
           if (nextAvailableVersion > this._doc.version) {
             // there are updates we still can't apply yet
           } else {

services/web/frontend/js/ide/editor/components/spellMenu.js

@@ -1,6 +1,5 @@
 /* eslint-disable
     max-len,
-    no-undef,
 */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.

services/web/frontend/js/ide/editor/controllers/SavingNotificationController.js

@@ -2,7 +2,6 @@
     camelcase,
     max-len,
     no-return-assign,
-    no-undef,
 */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.

services/web/frontend/js/ide/editor/directives/aceEditor/auto-complete/CommandManager.js

@@ -1,7 +1,6 @@
 /* eslint-disable
     max-len,
     no-return-assign,
-    no-undef,
     no-unused-vars,
 */
 // TODO: This file was created by bulk-decaffeinate.

services/web/frontend/js/ide/editor/directives/aceEditor/auto-complete/EnvironmentManager.js

@@ -1,6 +1,5 @@
 /* eslint-disable
     max-len,
-    no-undef,
 */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.

services/web/frontend/js/ide/editor/directives/aceEditor/auto-complete/Helpers.js

@@ -1,7 +1,6 @@
 /* eslint-disable
     max-len,
     no-cond-assign,
-    no-undef,
 */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.

services/web/frontend/js/ide/editor/directives/aceEditor/auto-complete/PackageManager.js

@@ -1,6 +1,5 @@
 /* eslint-disable
     max-len,
-    no-undef,
 */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.

services/web/frontend/js/ide/editor/directives/aceEditor/auto-complete/snippets/Environments.js

@@ -1,5 +1,4 @@
 /* eslint-disable
-    no-undef,
 */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.

services/web/frontend/js/ide/editor/directives/aceEditor/auto-complete/snippets/TopHundredSnippets.js

@@ -1,5 +1,4 @@
 /* eslint-disable
-    no-undef,
 */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.

services/web/frontend/js/ide/editor/directives/aceEditor/cursor-position/CursorPositionAdapter.js

@@ -1,6 +1,5 @@
 /* eslint-disable
     max-len,
-    no-undef,
     no-unused-vars,
 */
 // TODO: This file was created by bulk-decaffeinate.

services/web/frontend/js/ide/editor/directives/aceEditor/cursor-position/CursorPositionManager.js

@@ -1,6 +1,5 @@
 /* eslint-disable
     max-len,
-    no-undef,
     no-unused-vars,
 */
 // TODO: This file was created by bulk-decaffeinate.

services/web/frontend/js/ide/editor/directives/aceEditor/highlights/HighlightsManager.js

@@ -2,7 +2,6 @@
     camelcase,
     max-len,
     no-return-assign,
-    no-undef,
     no-unused-vars,
 */
 // TODO: This file was created by bulk-decaffeinate.

services/web/frontend/js/ide/editor/directives/aceEditor/metadata/MetadataManager.js

@@ -1,7 +1,6 @@
 /* eslint-disable
     max-len,
     no-cond-assign,
-    no-undef,
     no-unused-vars,
 */
 // TODO: This file was created by bulk-decaffeinate.

services/web/frontend/js/ide/editor/directives/aceEditor/spell-check/HighlightedWordManager.js

@@ -1,7 +1,6 @@
 /* eslint-disable
     max-len,
     no-return-assign,
-    no-undef,
     no-unused-vars,
 */
 // TODO: This file was created by bulk-decaffeinate.

services/web/frontend/js/ide/editor/directives/toggleSwitch.js

@@ -1,6 +1,5 @@
 /* eslint-disable
     max-len,
-    no-undef,
 */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.

services/web/frontend/js/ide/file-tree/FileTreeManager.js

@@ -4,7 +4,6 @@
     max-len,
     no-dupe-class-members,
     no-return-assign,
-    no-undef,
     no-unused-vars,
 */
 // TODO: This file was created by bulk-decaffeinate.

services/web/frontend/js/ide/file-tree/controllers/FileTreeController.js

@@ -3,7 +3,6 @@
     handle-callback-err,
     max-len,
     no-return-assign,
-    no-undef,
     no-unused-vars,
 */
 // TODO: This file was created by bulk-decaffeinate.
@@ -182,7 +181,7 @@ define(['../../../base'], function(App) {
       }
     })
     return $scope.$on('done', (e, opts = {}) => {
-      isBibFile = opts.name && /^.*\.bib$/.test(opts.name)
+      const isBibFile = opts.name && /^.*\.bib$/.test(opts.name)
       if (opts.shouldReindexReferences || isBibFile) {
         ide.$scope.$emit('references:should-reindex', {})
       }

services/web/frontend/js/ide/file-tree/controllers/FileTreeEntityController.js

@@ -2,7 +2,6 @@
     chai-friendly/no-unused-expressions,
     max-len,
     no-return-assign,
-    no-undef,
 */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.

services/web/frontend/js/ide/file-tree/controllers/FileTreeFolderController.js

@@ -2,7 +2,6 @@
     camelcase,
     max-len,
     no-return-assign,
-    no-undef,
 */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.

services/web/frontend/js/ide/file-tree/controllers/FileTreeRootFolderController.js

@@ -2,7 +2,6 @@
     camelcase,
     max-len,
     no-return-assign,
-    no-undef,
 */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.

services/web/frontend/js/ide/file-tree/directives/draggable.js

@@ -1,5 +1,4 @@
 /* eslint-disable
-    no-undef,
 */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.

services/web/frontend/js/ide/file-tree/directives/droppable.js

@@ -1,5 +1,4 @@
 /* eslint-disable
-    no-undef,
 */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.

services/web/frontend/js/ide/file-tree/directives/fileEntity.js

@@ -1,7 +1,6 @@
 /* eslint-disable
     max-len,
     no-return-assign,
-    no-undef,
 */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.

services/web/frontend/js/ide/file-tree/util/iconTypeFromName.js

@@ -1,7 +1,6 @@
 /* eslint-disable
     max-len,
     no-return-assign,
-    no-undef,
     no-unused-vars,
 */
 // TODO: This file was created by bulk-decaffeinate.

services/web/frontend/js/ide/graphics/services/graphics.js

@@ -1,6 +1,5 @@
 /* eslint-disable
     max-len,
-    no-undef,
 */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.

services/web/frontend/js/ide/history/HistoryManager.js

@@ -2,7 +2,6 @@
     camelcase,
     max-len,
     no-return-assign,
-    no-undef,
     no-unused-vars,
 */
 // TODO: This file was created by bulk-decaffeinate.

services/web/frontend/js/ide/history/HistoryV2Manager.js

@@ -2,7 +2,6 @@
     camelcase,
     max-len,
     no-return-assign,
-    no-undef,
     no-unused-vars,
 */
 // TODO: This file was created by bulk-decaffeinate.
@@ -401,13 +400,13 @@ define([
           )
           filesWithOps = []
           if (currentUpdate != null) {
-            for (pathname of currentUpdate.pathnames) {
+            for (let pathname of currentUpdate.pathnames) {
               filesWithOps.push({
                 pathname: pathname,
                 operation: 'edited'
               })
             }
-            for (op of currentUpdate.project_ops) {
+            for (let op of currentUpdate.project_ops) {
               let fileWithOp
               if (op.add != null) {
                 fileWithOp = {

services/web/frontend/js/ide/history/components/historyEntriesList.js

@@ -1,7 +1,6 @@
 /* eslint-disable
     max-len,
     no-return-assign,
-    no-undef,
 */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.

services/web/frontend/js/ide/history/components/historyEntry.js

@@ -1,6 +1,5 @@
 /* eslint-disable
     max-len,
-    no-undef,
 */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.

services/web/frontend/js/ide/history/components/historyFileEntity.js

@@ -1,7 +1,6 @@
 /* eslint-disable
     max-len,
     no-return-assign,
-    no-undef,
 */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.

services/web/frontend/js/ide/history/components/historyFileTree.js

@@ -1,5 +1,4 @@
 /* eslint-disable
-    no-undef,
 */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.

services/web/frontend/js/ide/history/components/historyLabel.js

@@ -1,6 +1,5 @@
 /* eslint-disable
     max-len,
-    no-undef,
 */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.

services/web/frontend/js/ide/history/components/historyLabelsList.js

@@ -1,6 +1,5 @@
 /* eslint-disable
     max-len,
-    no-undef,
 */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.

services/web/frontend/js/ide/history/controllers/HistoryDiffController.js

@@ -2,7 +2,6 @@
     camelcase,
     max-len,
     no-return-assign,
-    no-undef,
 */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.

services/web/frontend/js/ide/history/controllers/HistoryListController.js

@@ -2,7 +2,6 @@
     camelcase,
     max-len,
     no-return-assign,
-    no-undef,
 */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.

services/web/frontend/js/ide/history/controllers/HistoryV2AddLabelModalController.js

@@ -1,7 +1,6 @@
 /* eslint-disable
     max-len,
     no-return-assign,
-    no-undef,
 */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.

services/web/frontend/js/ide/history/controllers/HistoryV2DeleteLabelModalController.js

@@ -1,7 +1,6 @@
 /* eslint-disable
     max-len,
     no-return-assign,
-    no-undef,
 */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.

services/web/frontend/js/ide/history/controllers/HistoryV2FileTreeController.js

@@ -1,7 +1,6 @@
 /* eslint-disable
     max-len,
     no-return-assign,
-    no-undef,
 */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.

services/web/frontend/js/ide/history/controllers/HistoryV2ListController.js

@@ -1,7 +1,6 @@
 /* eslint-disable
     max-len,
     no-return-assign,
-    no-undef,
 */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.

services/web/frontend/js/ide/history/controllers/HistoryV2ToolbarController.js

@@ -1,7 +1,6 @@
 /* eslint-disable
     max-len,
     no-return-assign,
-    no-undef,
     camelcase,
 */
 // TODO: This file was created by bulk-decaffeinate.

services/web/frontend/js/ide/history/directives/infiniteScroll.js

@@ -1,6 +1,5 @@
 /* eslint-disable
     max-len,
-    no-undef,
 */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.

services/web/frontend/js/ide/history/util/HistoryViewModes.js

@@ -1,6 +1,5 @@
 /* eslint-disable
     no-return-assign,
-    no-undef,
     no-unused-vars,
 */
 // TODO: This file was created by bulk-decaffeinate.

services/web/frontend/js/ide/history/util/displayNameForUser.js

@@ -1,7 +1,6 @@
 /* eslint-disable
     max-len,
     no-return-assign,
-    no-undef,
     no-unused-vars,
 */
 // TODO: This file was created by bulk-decaffeinate.

services/web/frontend/js/ide/hotkeys/BackspaceHighjack.js

@@ -1,6 +1,5 @@
 /* eslint-disable
     max-len,
-    no-undef,
 */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.

services/web/frontend/js/ide/hotkeys/controllers/HotkeysController.js

@@ -2,7 +2,6 @@
     camelcase,
     max-len,
     no-return-assign,
-    no-undef,
 */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.

services/web/frontend/js/ide/hotkeys/index.js

@@ -1,5 +1,4 @@
 /* eslint-disable
-    no-undef,
 */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.

services/web/frontend/js/ide/human-readable-logs/HumanReadableLogs.js

@@ -1,6 +1,5 @@
 /* eslint-disable
     max-len,
-    no-undef,
 */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.

services/web/frontend/js/ide/human-readable-logs/HumanReadableLogsRules.js

@@ -1,6 +1,5 @@
 /* eslint-disable
     max-len,
-    no-undef,
     no-useless-escape,
 */
 // TODO: This file was created by bulk-decaffeinate.

services/web/frontend/js/ide/metadata/MetadataManager.js

@@ -1,6 +1,5 @@
 /* eslint-disable
     max-len,
-    no-undef,
     no-unused-vars,
 */
 // TODO: This file was created by bulk-decaffeinate.

services/web/frontend/js/ide/metadata/services/metadata.js

@@ -1,6 +1,5 @@
 /* eslint-disable
     no-return-assign,
-    no-undef,
 */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.

services/web/frontend/js/ide/online-users/OnlineUsersManager.js

@@ -3,7 +3,6 @@
     handle-callback-err,
     max-len,
     no-return-assign,
-    no-undef,
 */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.

services/web/frontend/js/ide/online-users/controllers/OnlineUsersController.js

@@ -1,7 +1,6 @@
 /* eslint-disable
     max-len,
     no-return-assign,
-    no-undef,
 */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.

services/web/frontend/js/ide/pdf/PdfManager.js

@@ -1,5 +1,4 @@
 /* eslint-disable
-    no-undef,
     no-unused-vars,
 */
 // TODO: This file was created by bulk-decaffeinate.

services/web/frontend/js/ide/pdf/controllers/PdfViewToggleController.js

@@ -1,6 +1,5 @@
 /* eslint-disable
     no-return-assign,
-    no-undef,
 */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.

services/web/frontend/js/ide/pdfng/directives/pdfHighlights.js

@@ -1,7 +1,6 @@
 /* eslint-disable
     max-len,
     no-return-assign,
-    no-undef,
     no-unused-vars,
 */
 // TODO: This file was created by bulk-decaffeinate.

services/web/frontend/js/ide/pdfng/directives/pdfJs.js

@@ -2,7 +2,6 @@
     max-len,
     no-cond-assign,
     no-return-assign,
-    no-undef,
 */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.

services/web/frontend/js/ide/pdfng/directives/pdfPage.js

@@ -2,7 +2,6 @@
     max-len,
     new-cap,
     no-return-assign,
-    no-undef,
 */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.

services/web/frontend/js/ide/pdfng/directives/pdfRenderer.js

@@ -3,7 +3,6 @@
     max-len,
     new-cap,
     no-return-assign,
-    no-undef,
     no-unused-vars,
 */
 // TODO: This file was created by bulk-decaffeinate.

services/web/frontend/js/ide/pdfng/directives/pdfSpinner.js

@@ -1,6 +1,5 @@
 /* eslint-disable
     max-len,
-    no-undef,
     no-unused-vars,
     no-useless-constructor,
 */

services/web/frontend/js/ide/pdfng/directives/pdfTextLayer.js

@@ -1,7 +1,6 @@
 /* eslint-disable
     max-len,
     no-return-assign,
-    no-undef,
     no-unused-vars,
 */
 // TODO: This file was created by bulk-decaffeinate.