Explorar el Código

Merge pull request #14674 from overleaf/jdt-prevent-menu-item-drags

feat: force all menuitems to be undraggable, and make home button und…
GitOrigin-RevId: 5b04a07aaca43b1eff8b50958d74356663b6d416
Jimmy Domagala-Tang hace 2 años
padre
commit
3aa6346ab3

+ 1 - 0
services/web/frontend/js/features/editor-navigation-toolbar/components/back-to-projects-button.tsx

@@ -15,6 +15,7 @@ function BackToProjectsButton() {
       <div className="toolbar-item">
         <a
           className="btn btn-full-height"
+          draggable="false"
           href="/project"
           onClick={() => {
             eventTracking.sendMB('navigation-clicked-home')

+ 1 - 0
services/web/frontend/js/features/pdf-preview/components/pdf-hybrid-download-button.tsx

@@ -32,6 +32,7 @@ function PdfHybridDownloadButton() {
       <Button
         onClick={handleOnClick}
         bsStyle="link"
+        draggable="false"
         disabled={!pdfDownloadUrl}
         download
         href={pdfDownloadUrl || '#'}

+ 1 - 1
services/web/frontend/js/shared/components/split-menu.tsx

@@ -138,7 +138,7 @@ function SplitMenuButton({
 }
 
 function SplitMenuItem(props: MenuItemProps) {
-  return <MenuItem {...props} />
+  return <MenuItem {...props} draggable="false" />
 }
 
 SplitMenu.Item = SplitMenuItem