Просмотр исходного кода

Merge pull request #10973 from overleaf/ab-split-test-dash-graphs-fix

[web] Include archived tests in split test dashboard stats

GitOrigin-RevId: 570b6b5431dce3060a756752d45535a681ae9087
Alexandre Bourdin 3 лет назад
Родитель
Сommit
4d4a610fd2
1 измененных файлов с 4 добавлено и 4 удалено
  1. 4 4
      services/web/app/src/Features/SplitTests/SplitTestManager.js

+ 4 - 4
services/web/app/src/Features/SplitTests/SplitTestManager.js

@@ -7,12 +7,12 @@ const ALPHA_PHASE = 'alpha'
 const BETA_PHASE = 'beta'
 const BETA_PHASE = 'beta'
 const RELEASE_PHASE = 'release'
 const RELEASE_PHASE = 'release'
 
 
-async function getSplitTests({ name, phase, type, activeOnly, archivedOnly }) {
+async function getSplitTests({ name, phase, type, active, archived }) {
   const filters = {}
   const filters = {}
   if (name && name !== '') {
   if (name && name !== '') {
     filters.name = { $regex: _.escapeRegExp(name) }
     filters.name = { $regex: _.escapeRegExp(name) }
   }
   }
-  if (activeOnly) {
+  if (active) {
     filters.$where = 'this.versions[this.versions.length - 1].active === true'
     filters.$where = 'this.versions[this.versions.length - 1].active === true'
   }
   }
   if (type === 'split-test') {
   if (type === 'split-test') {
@@ -41,9 +41,9 @@ async function getSplitTests({ name, phase, type, activeOnly, archivedOnly }) {
       filters.$where = query
       filters.$where = query
     }
     }
   }
   }
-  if (archivedOnly) {
+  if (archived === true) {
     filters.archived = true
     filters.archived = true
-  } else {
+  } else if (archived === false) {
     filters.archived = { $ne: true }
     filters.archived = { $ne: true }
   }
   }
   try {
   try {