Merge pull request #5573 from overleaf/jpa-prefer-regex-literals

[misc] fix eslint violations for prefer-regex-literals

GitOrigin-RevId: 216288af22b9eeb18cddace7ec285e0a8046f94a

services/chat/.eslintrc

@@ -20,11 +20,6 @@
     "mocha": true
   },
   "rules": {
-    // TODO(das7pad): remove overrides after fixing all the violations manually (https://github.com/overleaf/issues/issues/3882#issuecomment-878999671)
-    // START of temporary overrides
-    "prefer-regex-literals": "off",
-    // END of temporary overrides
-
     // Swap the no-unused-expressions rule with a more chai-friendly one
     "no-unused-expressions": 0,
     "chai-friendly/no-unused-expressions": "error",

services/clsi/.eslintrc

@@ -20,11 +20,6 @@
     "mocha": true
   },
   "rules": {
-    // TODO(das7pad): remove overrides after fixing all the violations manually (https://github.com/overleaf/issues/issues/3882#issuecomment-878999671)
-    // START of temporary overrides
-    "prefer-regex-literals": "off",
-    // END of temporary overrides
-
     // Swap the no-unused-expressions rule with a more chai-friendly one
     "no-unused-expressions": 0,
     "chai-friendly/no-unused-expressions": "error",

services/contacts/.eslintrc

@@ -20,11 +20,6 @@
     "mocha": true
   },
   "rules": {
-    // TODO(das7pad): remove overrides after fixing all the violations manually (https://github.com/overleaf/issues/issues/3882#issuecomment-878999671)
-    // START of temporary overrides
-    "prefer-regex-literals": "off",
-    // END of temporary overrides
-
     // Swap the no-unused-expressions rule with a more chai-friendly one
     "no-unused-expressions": 0,
     "chai-friendly/no-unused-expressions": "error",

services/docstore/.eslintrc

@@ -20,11 +20,6 @@
     "mocha": true
   },
   "rules": {
-    // TODO(das7pad): remove overrides after fixing all the violations manually (https://github.com/overleaf/issues/issues/3882#issuecomment-878999671)
-    // START of temporary overrides
-    "prefer-regex-literals": "off",
-    // END of temporary overrides
-
     // Swap the no-unused-expressions rule with a more chai-friendly one
     "no-unused-expressions": 0,
     "chai-friendly/no-unused-expressions": "error",

services/document-updater/.eslintrc

@@ -20,11 +20,6 @@
     "mocha": true
   },
   "rules": {
-    // TODO(das7pad): remove overrides after fixing all the violations manually (https://github.com/overleaf/issues/issues/3882#issuecomment-878999671)
-    // START of temporary overrides
-    "prefer-regex-literals": "off",
-    // END of temporary overrides
-
     // Swap the no-unused-expressions rule with a more chai-friendly one
     "no-unused-expressions": 0,
     "chai-friendly/no-unused-expressions": "error",

services/filestore/.eslintrc

@@ -20,11 +20,6 @@
     "mocha": true
   },
   "rules": {
-    // TODO(das7pad): remove overrides after fixing all the violations manually (https://github.com/overleaf/issues/issues/3882#issuecomment-878999671)
-    // START of temporary overrides
-    "prefer-regex-literals": "off",
-    // END of temporary overrides
-
     // Swap the no-unused-expressions rule with a more chai-friendly one
     "no-unused-expressions": 0,
     "chai-friendly/no-unused-expressions": "error",

services/filestore/test/acceptance/js/TestConfig.js

@@ -26,7 +26,7 @@ function gcsConfig() {
       apiScheme: process.env.GCS_API_SCHEME,
       projectId: 'fake',
     },
-    directoryKeyRegex: new RegExp('^[0-9a-fA-F]{24}/[0-9a-fA-F]{24}'),
+    directoryKeyRegex: /^[0-9a-fA-F]{24}\/[0-9a-fA-F]{24}/,
     unlockBeforeDelete: false, // fake-gcs does not support this
     deletedBucketSuffix: '-deleted',
   }

services/notifications/.eslintrc

@@ -20,11 +20,6 @@
     "mocha": true
   },
   "rules": {
-    // TODO(das7pad): remove overrides after fixing all the violations manually (https://github.com/overleaf/issues/issues/3882#issuecomment-878999671)
-    // START of temporary overrides
-    "prefer-regex-literals": "off",
-    // END of temporary overrides
-
     // Swap the no-unused-expressions rule with a more chai-friendly one
     "no-unused-expressions": 0,
     "chai-friendly/no-unused-expressions": "error",

services/real-time/.eslintrc

@@ -20,11 +20,6 @@
     "mocha": true
   },
   "rules": {
-    // TODO(das7pad): remove overrides after fixing all the violations manually (https://github.com/overleaf/issues/issues/3882#issuecomment-878999671)
-    // START of temporary overrides
-    "prefer-regex-literals": "off",
-    // END of temporary overrides
-
     // Swap the no-unused-expressions rule with a more chai-friendly one
     "no-unused-expressions": 0,
     "chai-friendly/no-unused-expressions": "error",

services/spelling/.eslintrc

@@ -20,11 +20,6 @@
     "mocha": true
   },
   "rules": {
-    // TODO(das7pad): remove overrides after fixing all the violations manually (https://github.com/overleaf/issues/issues/3882#issuecomment-878999671)
-    // START of temporary overrides
-    "prefer-regex-literals": "off",
-    // END of temporary overrides
-
     // Swap the no-unused-expressions rule with a more chai-friendly one
     "no-unused-expressions": 0,
     "chai-friendly/no-unused-expressions": "error",

services/spelling/app/js/ASpellWorker.js

@@ -113,7 +113,7 @@ class ASpellWorker {
 
     this.pipe.stdout.setEncoding('utf8') // ensure utf8 output is handled correctly
     let output = ''
-    const endMarkerRegex = new RegExp('^[a-z][a-z]', 'gm')
+    const endMarkerRegex = /^[a-z]{2}/gm
     this.pipe.stdout.on('data', data => {
       // We receive the language code from Aspell as the end of data marker in
       // the data.  The input is a utf8 encoded string.

services/track-changes/.eslintrc

@@ -20,11 +20,6 @@
     "mocha": true
   },
   "rules": {
-    // TODO(das7pad): remove overrides after fixing all the violations manually (https://github.com/overleaf/issues/issues/3882#issuecomment-878999671)
-    // START of temporary overrides
-    "prefer-regex-literals": "off",
-    // END of temporary overrides
-
     // Swap the no-unused-expressions rule with a more chai-friendly one
     "no-unused-expressions": 0,
     "chai-friendly/no-unused-expressions": "error",