Kaynağa Gözat

Merge pull request #25008 from overleaf/msm-missing-close-handler-modal

[web] Fix `cancel` button in `UnlinkUserModal`.

GitOrigin-RevId: 5b84c9593ce59c6da9aae9cf4f8e763151202d34
Miguel Serrano 1 yıl önce
ebeveyn
işleme
707e197625

+ 5 - 1
services/web/frontend/js/features/group-management/components/members-table/unlink-user-modal.tsx

@@ -108,7 +108,11 @@ export default function UnlinkUserModal({
         </p>
       </OLModalBody>
       <OLModalFooter>
-        <OLButton variant="secondary" disabled={unlinkInFlight}>
+        <OLButton
+          variant="secondary"
+          disabled={unlinkInFlight}
+          onClick={onClose}
+        >
           {t('cancel')}
         </OLButton>
         <OLButton

+ 9 - 0
services/web/test/frontend/features/group-management/components/members-table/unlink-user-modal.test.tsx

@@ -58,6 +58,15 @@ describe('<UnlinkUserModal />', function () {
     await waitFor(() => expect(defaultProps.onClose).to.have.been.called)
   })
 
+  it('closes the modal on cancelling', async function () {
+    renderWithContext(<UnlinkUserModal {...defaultProps} />)
+
+    const cancelButton = screen.getByRole('button', { name: 'Cancel' })
+    fireEvent.click(cancelButton)
+
+    await waitFor(() => expect(defaultProps.onClose).to.have.been.called)
+  })
+
   it('handles errors', async function () {
     fetchMock.post(`/manage/groups/${groupId}/unlink-user/${userId}`, 500)