Przeglądaj źródła

Add `is-screen-width-less-than-768px` to the `upgrade-button-click` event (#11506)

GitOrigin-RevId: 33ae53d7959863017607d3e1ea237602aed626dc
M Fahru 3 lat temu
rodzic
commit
78304e7c94

+ 1 - 1
services/web/app/views/layout/navbar-marketing.pug

@@ -17,7 +17,7 @@ nav.navbar.navbar-default.navbar-main
 					event-tracking-mb="true"
 					event-tracking-label="upgrade"
 					event-tracking-trigger="click"
-					event-segmentation='{"source": "dashboard-top", "project-dashboard-react": "enabled", "is-dashboard-sidebar-hidden": "true"}'
+					event-segmentation='{"source": "dashboard-top", "project-dashboard-react": "enabled", "is-dashboard-sidebar-hidden": "true", "is-screen-width-less-than-768px": "true"}'
 				) #{translate("upgrade")}
 			if settings.nav.custom_logo
 				a(href='/', aria-label=settings.appName, style='background-image:url("'+settings.nav.custom_logo+'")').navbar-brand

+ 1 - 5
services/web/app/views/project/list/_current_plan_mixins.pug

@@ -108,9 +108,5 @@ mixin free_plan()
 		|  
 	a.btn.btn-primary(
 		href="/user/subscription/plans?itm_referrer=project-dashboard-upgrade-prompt"
-		event-tracking="upgrade-button-click"
-		event-tracking-mb="true"
-		event-tracking-label="upgrade"
-		event-tracking-trigger="click"
-		event-segmentation='{"source": "dashboard-top", "project-dashboard-react": "default", "is-dashboard-sidebar-hidden": "false"}'
+		ng-click="sendUpgradeButtonClickEvent()"
 	) Upgrade

+ 1 - 0
services/web/frontend/js/features/project-list/components/current-plan-widget/free-plan.tsx

@@ -18,6 +18,7 @@ function FreePlan({ featuresPageURL }: FreePlanProps) {
       source: 'dashboard-top',
       'project-dashboard-react': 'enabled',
       'is-dashboard-sidebar-hidden': false,
+      'is-screen-width-less-than-768px': false,
     })
   }
 

+ 10 - 0
services/web/frontend/js/main/project-list/project-list.js

@@ -821,6 +821,16 @@ App.controller(
     $scope.downloadSelectedProjects = () =>
       $scope.downloadProjectsById($scope.getSelectedProjectIds())
 
+    $scope.sendUpgradeButtonClickEvent = () => {
+      eventTracking.sendMB('upgrade-button-click', {
+        source: 'dashboard-top',
+        'project-dashboard-react': 'default',
+        'is-dashboard-sidebar-hidden': false,
+        'is-screen-width-less-than-768px':
+          window.matchMedia('(max-width: 767px)').matches,
+      })
+    }
+
     $scope.downloadProjectsById = function (projectIds) {
       let path
       eventTracking.send(

+ 1 - 0
services/web/test/frontend/features/project-list/components/current-plan-widget.test.tsx

@@ -55,6 +55,7 @@ describe('<CurrentPlanWidget />', function () {
         page: '/',
         'project-dashboard-react': 'enabled',
         'is-dashboard-sidebar-hidden': false,
+        'is-screen-width-less-than-768px': false,
       })
     })
   })