Kaynağa Gözat

Merge pull request #3919 from overleaf/jpa-refactor-inline-script

[views] referal/bonus: refactor inline script in event handler

GitOrigin-RevId: 825f15c1badf964e0e0e2c9bc42951a5f318b357
Timothée Alby 5 yıl önce
ebeveyn
işleme
7d0f117918
1 değiştirilmiş dosya ile 4 ekleme ve 2 silme
  1. 4 2
      services/web/app/views/referal/bonus.pug

+ 4 - 2
services/web/app/views/referal/bonus.pug

@@ -32,7 +32,7 @@ block content
 							.row
 							.row
 								.col-md-8.col-md-offset-2.bonus-banner
 								.col-md-8.col-md-offset-2.bonus-banner
 									.title
 									.title
-										a(href='#', onclick='postToFeed(); return false;').facebook
+										a(href='#').facebook
 											i.fa.fa-fw.fa-2x.fa-facebook-square(aria-hidden="true")
 											i.fa.fa-fw.fa-2x.fa-facebook-square(aria-hidden="true")
 											|
 											|
 											| #{translate("post_on_facebook")}
 											| #{translate("post_on_facebook")}
@@ -158,8 +158,10 @@ block append foot-scripts
 			$(".email").click(function() {
 			$(".email").click(function() {
 				ga('send', 'event', 'referal-button', 'clicked', "email")
 				ga('send', 'event', 'referal-button', 'clicked', "email")
 			});
 			});
-			$(".facebook").click(function() {
+			$(".facebook").click(function(e) {
 				ga('send', 'event', 'referal-button', 'clicked', "facebook")
 				ga('send', 'event', 'referal-button', 'clicked', "facebook")
+				postToFeed()
+				e.preventDefault()
 			});
 			});
 			$(".link").click(function() {
 			$(".link").click(function() {
 				ga('send', 'event', 'referal-button', 'clicked', "direct-link")
 				ga('send', 'event', 'referal-button', 'clicked', "direct-link")