Просмотр исходного кода

Ensure that onTimeoutHandler is called when there are unacknowledged edits (#18340)

GitOrigin-RevId: aa6430d7e32f6e27b67f92b187dbb13349fc6a40
Alf Eaton 2 лет назад
Родитель
Сommit
81559967f2

+ 4 - 2
services/web/frontend/js/features/ide-react/connection/editor-watchdog-manager.ts

@@ -126,7 +126,9 @@ class Reporter {
       // Another handler processed the 'meta' entry already
       if (!this.queue.length) return
 
-      const maybeLocalMeta = this.getMetaPreferLocal()
+      // There is always an item on the queue at this point,
+      // so getMetaPreferLocal will always return a Meta object
+      const maybeLocalMeta = this.getMetaPreferLocal() as Meta
 
       // Discard other, newly arrived 'meta's
       this.queue.length = 0
@@ -135,7 +137,7 @@ class Reporter {
       // Do not flood the server with losing-edits events
       const reportedRecently =
         this.lastReport !== null && now - this.lastReport < REPORT_EVERY
-      if (!reportedRecently && maybeLocalMeta) {
+      if (!reportedRecently) {
         this.lastReport = now
         this.onTimeoutHandler(maybeLocalMeta)
       }