Merge pull request #1080 from sharelatex/as-fix-linting

Fix linting not running on modules

GitOrigin-RevId: 12a27fc9e1c9b41202e04b6272e5b42289603f3a

services/web/.eslintignore

@@ -1,8 +1,12 @@
 app/js
-modules
+modules/**/app/js
+modules/**/scripts
+modules/**/index.js
 public/js
 public/minjs
+modules/**/public/js
 test/**/js
+modules/**/test/**/js
 app.js
 webpack.config.*
 karma.conf.js

services/web/.eslintrc

@@ -1,6 +1,12 @@
 {
-  "extends": ["standard"],
+  "extends": [
+    "standard",
+    "standard-react",
+    "plugin:jsx-a11y/recommended"
+  ],
   "plugins": [
+    "jsx-a11y",
+    "mocha",
     "chai-expect",
     "chai-friendly"
   ],
@@ -10,12 +16,42 @@
   "globals": {
     "expect": true
   },
+  "settings": {
+    // Tell eslint-plugin-react which version of React we are using
+    "react": {
+      "version": "15"
+    }
+  },
   "rules": {
     "max-len": ["error", {
       // Ignore long describe/it test blocks
+      "ignoreUrls": true,
       "ignorePattern": "^\\s*(it|describe)\\s*\\(['\"]"
     }],
 
+    // Override weird behaviour of jsx-a11y label-has-for (says labels must be
+    // nested *and* have for/id attributes)
+    "jsx-a11y/label-has-for": [
+      "error",
+      {
+        "required": {
+          "some": [
+            "nesting",
+            "id"
+          ]
+        }
+      }
+    ],
+
+    // Add some mocha specific rules
+    "mocha/handle-done-callback": "error",
+    "mocha/no-exclusive-tests": "error",
+    "mocha/no-global-tests": "error",
+    "mocha/no-identical-title": "error",
+    "mocha/no-nested-tests": "error",
+    "mocha/no-pending-tests": "error",
+    "mocha/no-skipped-tests": "error",
+
     // Add some chai specific rules
     "chai-expect/missing-assertion": "error",
     "chai-expect/terminating-properties": "error",

services/web/npm-shrinkwrap.json

@@ -244,6 +244,20 @@
         }
       }
     },
+    "aria-query": {
+      "version": "3.0.0",
+      "from": "aria-query@>=3.0.0 <4.0.0",
+      "resolved": "https://registry.npmjs.org/aria-query/-/aria-query-3.0.0.tgz",
+      "dev": true,
+      "dependencies": {
+        "commander": {
+          "version": "2.19.0",
+          "from": "commander@>=2.11.0 <3.0.0",
+          "resolved": "https://registry.npmjs.org/commander/-/commander-2.19.0.tgz",
+          "dev": true
+        }
+      }
+    },
     "arr-diff": {
       "version": "2.0.0",
       "from": "arr-diff@>=2.0.0 <3.0.0",
@@ -360,6 +374,12 @@
       "dev": true,
       "optional": true
     },
+    "ast-types-flow": {
+      "version": "0.0.7",
+      "from": "ast-types-flow@>=0.0.7 <0.0.8",
+      "resolved": "https://registry.npmjs.org/ast-types-flow/-/ast-types-flow-0.0.7.tgz",
+      "dev": true
+    },
     "async": {
       "version": "0.6.2",
       "from": "async@0.6.2",
@@ -433,6 +453,12 @@
       "from": "axo@>=0.0.0 <0.1.0",
       "resolved": "https://registry.npmjs.org/axo/-/axo-0.0.2.tgz"
     },
+    "axobject-query": {
+      "version": "2.0.2",
+      "from": "axobject-query@>=2.0.1 <3.0.0",
+      "resolved": "https://registry.npmjs.org/axobject-query/-/axobject-query-2.0.2.tgz",
+      "dev": true
+    },
     "babel-code-frame": {
       "version": "6.26.0",
       "from": "babel-code-frame@>=6.26.0 <7.0.0",
@@ -2175,6 +2201,12 @@
       "from": "d3@3.5.16",
       "resolved": "https://registry.npmjs.org/d3/-/d3-3.5.16.tgz"
     },
+    "damerau-levenshtein": {
+      "version": "1.0.4",
+      "from": "damerau-levenshtein@>=1.0.0 <2.0.0",
+      "resolved": "https://registry.npmjs.org/damerau-levenshtein/-/damerau-levenshtein-1.0.4.tgz",
+      "dev": true
+    },
     "dashdash": {
       "version": "1.14.1",
       "from": "dashdash@>=1.12.0 <2.0.0",
@@ -2596,6 +2628,12 @@
       "resolved": "https://registry.npmjs.org/elliptic/-/elliptic-6.4.0.tgz",
       "dev": true
     },
+    "emoji-regex": {
+      "version": "6.5.1",
+      "from": "emoji-regex@>=6.5.1 <7.0.0",
+      "resolved": "https://registry.npmjs.org/emoji-regex/-/emoji-regex-6.5.1.tgz",
+      "dev": true
+    },
     "emojis-list": {
       "version": "2.1.0",
       "from": "emojis-list@>=2.0.0 <3.0.0",
@@ -2915,6 +2953,18 @@
       "resolved": "https://registry.npmjs.org/eslint-config-standard/-/eslint-config-standard-11.0.0.tgz",
       "dev": true
     },
+    "eslint-config-standard-jsx": {
+      "version": "5.0.0",
+      "from": "eslint-config-standard-jsx@>=5.0.0 <6.0.0",
+      "resolved": "https://registry.npmjs.org/eslint-config-standard-jsx/-/eslint-config-standard-jsx-5.0.0.tgz",
+      "dev": true
+    },
+    "eslint-config-standard-react": {
+      "version": "6.0.0",
+      "from": "eslint-config-standard-react@>=6.0.0 <7.0.0",
+      "resolved": "https://registry.npmjs.org/eslint-config-standard-react/-/eslint-config-standard-react-6.0.0.tgz",
+      "dev": true
+    },
     "eslint-import-resolver-node": {
       "version": "0.3.2",
       "from": "eslint-import-resolver-node@>=0.3.1 <0.4.0",
@@ -3011,6 +3061,26 @@
         }
       }
     },
+    "eslint-plugin-jsx-a11y": {
+      "version": "6.1.2",
+      "from": "eslint-plugin-jsx-a11y@latest",
+      "resolved": "https://registry.npmjs.org/eslint-plugin-jsx-a11y/-/eslint-plugin-jsx-a11y-6.1.2.tgz",
+      "dev": true,
+      "dependencies": {
+        "has": {
+          "version": "1.0.3",
+          "from": "has@>=1.0.3 <2.0.0",
+          "resolved": "https://registry.npmjs.org/has/-/has-1.0.3.tgz",
+          "dev": true
+        }
+      }
+    },
+    "eslint-plugin-mocha": {
+      "version": "5.2.0",
+      "from": "eslint-plugin-mocha@latest",
+      "resolved": "https://registry.npmjs.org/eslint-plugin-mocha/-/eslint-plugin-mocha-5.2.0.tgz",
+      "dev": true
+    },
     "eslint-plugin-node": {
       "version": "6.0.1",
       "from": "eslint-plugin-node@>=6.0.0 <7.0.0",
@@ -3037,6 +3107,26 @@
       "resolved": "https://registry.npmjs.org/eslint-plugin-promise/-/eslint-plugin-promise-3.7.0.tgz",
       "dev": true
     },
+    "eslint-plugin-react": {
+      "version": "7.11.1",
+      "from": "eslint-plugin-react@>=7.11.1 <8.0.0",
+      "resolved": "https://registry.npmjs.org/eslint-plugin-react/-/eslint-plugin-react-7.11.1.tgz",
+      "dev": true,
+      "dependencies": {
+        "has": {
+          "version": "1.0.3",
+          "from": "has@>=1.0.3 <2.0.0",
+          "resolved": "https://registry.npmjs.org/has/-/has-1.0.3.tgz",
+          "dev": true
+        },
+        "prop-types": {
+          "version": "15.6.2",
+          "from": "prop-types@>=15.6.2 <16.0.0",
+          "resolved": "https://registry.npmjs.org/prop-types/-/prop-types-15.6.2.tgz",
+          "dev": true
+        }
+      }
+    },
     "eslint-plugin-standard": {
       "version": "3.1.0",
       "from": "eslint-plugin-standard@>=3.0.1 <4.0.0",
@@ -5457,6 +5547,12 @@
         }
       }
     },
+    "jsx-ast-utils": {
+      "version": "2.0.1",
+      "from": "jsx-ast-utils@>=2.0.1 <3.0.0",
+      "resolved": "https://registry.npmjs.org/jsx-ast-utils/-/jsx-ast-utils-2.0.1.tgz",
+      "dev": true
+    },
     "just-extend": {
       "version": "1.1.27",
       "from": "just-extend@>=1.1.26 <2.0.0",
@@ -8996,6 +9092,12 @@
       "resolved": "https://registry.npmjs.org/querystringify/-/querystringify-0.0.4.tgz",
       "dev": true
     },
+    "ramda": {
+      "version": "0.25.0",
+      "from": "ramda@>=0.25.0 <0.26.0",
+      "resolved": "https://registry.npmjs.org/ramda/-/ramda-0.25.0.tgz",
+      "dev": true
+    },
     "random-bytes": {
       "version": "1.0.0",
       "from": "random-bytes@>=1.0.0 <1.1.0",

services/web/package.json

@@ -119,11 +119,16 @@
     "es6-promise": "^4.0.5",
     "eslint": "^4.18.1",
     "eslint-config-standard": "^11.0.0",
+    "eslint-config-standard-jsx": "^5.0.0",
+    "eslint-config-standard-react": "^6.0.0",
     "eslint-plugin-chai-expect": "^1.1.1",
     "eslint-plugin-chai-friendly": "^0.4.1",
     "eslint-plugin-import": "^2.9.0",
+    "eslint-plugin-jsx-a11y": "^6.1.2",
+    "eslint-plugin-mocha": "^5.2.0",
     "eslint-plugin-node": "^6.0.0",
     "eslint-plugin-promise": "^3.6.0",
+    "eslint-plugin-react": "^7.11.1",
     "eslint-plugin-standard": "^3.0.1",
     "grunt": "0.4.5",
     "grunt-available-tasks": "0.4.1",