Browse Source

Merge pull request #18377 from overleaf/td-metrics-page-fix

Move Bootstrap and jQuery imports into metricsApp

GitOrigin-RevId: 3ec1690ca60928e983211792f6c6b63548dfe62c
Tim Down 2 years ago
parent
commit
97add91248

+ 6 - 0
services/web/app/views/_mixins/foot_scripts.pug

@@ -0,0 +1,6 @@
+mixin foot-scripts()
+	each file in entrypointScripts(entrypoint)
+		script(type="text/javascript", nonce=scriptNonce, src=file, defer=deferScripts)
+	if (settings.splitTest.devToolbar.enabled)
+		each file in entrypointScripts("devToolbar")
+			script(type="text/javascript", nonce=scriptNonce, src=file, defer=deferScripts)

+ 4 - 6
services/web/app/views/layout-base.pug

@@ -1,3 +1,5 @@
+include ./_mixins/foot_scripts
+
 doctype html
 html(
 	lang=(currentLngCode || 'en')
@@ -82,12 +84,8 @@ html(
 			div#dev-toolbar
 
 	block foot-scripts
-		each file in entrypointScripts(entrypoint)
-			script(type="text/javascript", nonce=scriptNonce, src=file, defer=deferScripts)
-		if (settings.splitTest.devToolbar.enabled)
-			each file in entrypointScripts("devToolbar")
-				script(type="text/javascript", nonce=scriptNonce, src=file, defer=deferScripts)
-	
+		+foot-scripts
+
 	script(type="text/javascript", nonce=scriptNonce).
 		window.addEventListener('DOMContentLoaded', function() {
 			//- Look for bundle