Merge pull request #21 from overleaf/ew-jpa-fix-express-deprecations

[misc] fix express deprecations

services/contacts/app.js

@@ -37,9 +37,9 @@ app.get('/status', (req, res) => res.send('contacts is alive'))
 app.use(function (error, req, res, next) {
   logger.error({ err: error }, 'request errored')
   if (error instanceof Errors.NotFoundError) {
-    return res.send(404)
+    return res.sendStatus(404)
   } else {
-    return res.send(500, 'Oops, something went wrong')
+    return res.status(500).send('Oops, something went wrong')
   }
 })
 

services/contacts/app/js/HttpController.js

@@ -33,7 +33,7 @@ module.exports = HttpController = {
         if (error != null) {
           return next(error)
         }
-        return res.status(204).end()
+        return res.sendStatus(204)
       })
     })
   },

services/contacts/test/unit/js/HttpControllerTests.js

@@ -33,6 +33,7 @@ describe('HttpController', function () {
     this.res.status = sinon.stub().returns(this.res)
     this.res.end = sinon.stub()
     this.res.send = sinon.stub()
+    this.res.sendStatus = sinon.stub()
     return (this.next = sinon.stub())
   })
 
@@ -61,8 +62,7 @@ describe('HttpController', function () {
       })
 
       return it('should send back a 204 status', function () {
-        this.res.status.calledWith(204).should.equal(true)
-        return this.res.end.called.should.equal(true)
+        this.res.sendStatus.calledWith(204).should.equal(true)
       })
     })