ソースを参照

[cm6] Wrap compile log annotations in a lint source (#8451)

GitOrigin-RevId: d404560313cbb99c7a06453bc3b7d2374e86598a
Alf Eaton 4 年 前
コミット
bd64a167f4

+ 1 - 1
services/web/frontend/js/features/pdf-preview/hooks/use-compile-triggers.js

@@ -37,5 +37,5 @@ export default function useCompileTriggers() {
     showPdfDetach ? setOrTriggerChangedAt(Date.now()) : setChangedAt(Date.now())
   }, [setOrTriggerChangedAt, setChangedAt])
   useEventListener('doc:changed', setChangedAtHandler)
-  useEventListener('doc:saved', setChangedAtHandler)
+  useEventListener('doc:saved', setChangedAtHandler) // TODO: store this separately?
 }

+ 1 - 1
services/web/frontend/js/features/pdf-preview/util/compiler.js

@@ -75,7 +75,7 @@ export default class DocumentCompiler {
 
     try {
       // reset values
-      this.setChangedAt(0)
+      this.setChangedAt(0) // TODO: wait for doc:saved?
       this.validationIssues = undefined
 
       window.dispatchEvent(new CustomEvent('flush-changes')) // TODO: wait for this?

+ 1 - 1
services/web/frontend/js/features/pdf-preview/util/output-files.js

@@ -143,7 +143,7 @@ export function buildLogEntryAnnotations(entries, fileTreeManager) {
           row: entry.line - 1,
           type: entry.level === 'error' ? 'error' : 'warning',
           text: entry.message,
-          source: 'compile',
+          source: 'compile', // NOTE: this is used in Ace for filtering the annotations
         })
       }
     }

+ 1 - 0
services/web/types/annotation.ts

@@ -2,4 +2,5 @@ export type Annotation = {
   row: number
   type: 'info' | 'warning' | 'error'
   text: string
+  source?: string
 }