Explorar o código

Merge pull request #23998 from overleaf/td-resolved-thread-count

Fix for resolved thread count display

GitOrigin-RevId: c4f6848ed2e952981d20f157466db6dded99c3c9
Tim Down hai 1 ano
pai
achega
cd644320f4

+ 5 - 5
services/web/frontend/js/features/review-panel-new/components/review-panel-resolved-threads-menu.tsx

@@ -50,18 +50,18 @@ export const ReviewPanelResolvedThreadsMenu: FC = () => {
       return []
       return []
     }
     }
 
 
-    const resolvedThreads = []
+    const allResolvedThreads = []
     for (const [id, thread] of Object.entries(threads)) {
     for (const [id, thread] of Object.entries(threads)) {
       if (thread.resolved) {
       if (thread.resolved) {
-        resolvedThreads.push({ thread, id })
+        allResolvedThreads.push({ thread, id })
       }
       }
     }
     }
-    resolvedThreads.sort((a, b) => {
+    allResolvedThreads.sort((a, b) => {
       return Date.parse(b.thread.resolved_at) - Date.parse(a.thread.resolved_at)
       return Date.parse(b.thread.resolved_at) - Date.parse(a.thread.resolved_at)
     })
     })
 
 
-    return resolvedThreads
-  }, [threads])
+    return allResolvedThreads.filter(thread => allComments.has(thread.id))
+  }, [threads, allComments])
 
 
   if (loading) {
   if (loading) {
     return <LoadingSpinner className="ms-auto me-auto" />
     return <LoadingSpinner className="ms-auto me-auto" />