Просмотр исходного кода

Merge pull request #7010 from overleaf/ab-mixpanel-backfill-program

[web] Skip backfilling user program membership if not set

GitOrigin-RevId: a8193ee7701cd3229f1eafef23d7d0ed87e9aedc
Alexandre Bourdin 4 лет назад
Родитель
Сommit
eb81b2b6de
1 измененных файлов с 9 добавлено и 2 удалено
  1. 9 2
      services/web/scripts/backfill_mixpanel_user_properties.js

+ 9 - 2
services/web/scripts/backfill_mixpanel_user_properties.js

@@ -18,8 +18,12 @@ async function processUser(user) {
   await _sendPropertyToQueue(analyticsId, 'user-id', user._id)
   await _sendPropertyToQueue(analyticsId, 'user-id', user._id)
   await _sendPropertyToQueue(analyticsId, 'analytics-id', analyticsId)
   await _sendPropertyToQueue(analyticsId, 'analytics-id', analyticsId)
   await _sendPropertyToQueue(analyticsId, 'created-at', user.signUpDate)
   await _sendPropertyToQueue(analyticsId, 'created-at', user.signUpDate)
-  await _sendPropertyToQueue(analyticsId, 'alpha-program', user.alphaProgram)
-  await _sendPropertyToQueue(analyticsId, 'beta-program', user.betaProgram)
+  if (user.alphaProgram !== undefined) {
+    await _sendPropertyToQueue(analyticsId, 'alpha-program', user.alphaProgram)
+  }
+  if (user.betaProgram !== undefined) {
+    await _sendPropertyToQueue(analyticsId, 'beta-program', user.betaProgram)
+  }
 
 
   const groupSubscriptionPlanCode = await _getGroupSubscriptionPlanCode(
   const groupSubscriptionPlanCode = await _getGroupSubscriptionPlanCode(
     user._id
     user._id
@@ -77,6 +81,9 @@ async function _sendPropertyToQueue(
   propertyValue,
   propertyValue,
   createdAt = new Date()
   createdAt = new Date()
 ) {
 ) {
+  if (propertyValue == null) {
+    return
+  }
   await mixpanelSinkQueue.add('user-property', {
   await mixpanelSinkQueue.add('user-property', {
     analyticsId,
     analyticsId,
     propertyName,
     propertyName,