Explorar el Código

Merge pull request #7548 from overleaf/jpa-login-instead

[web] add "Log in instead" split test and click tracking in navbar

GitOrigin-RevId: c3893540220292bdf44b30aa0c9fb2aacca2863a
Jakob Ackermann hace 4 años
padre
commit
f1f9771150

+ 16 - 2
services/web/app/views/layout/navbar-marketing.pug

@@ -105,11 +105,25 @@ nav.navbar.navbar-default.navbar-main
 					// register link
 					if hasFeature('registration-page')
 						li
-							a(href="/register") #{translate('register')}
+							a(
+								href="/register"
+								event-tracking="menu-clicked-register"
+								event-tracking-action="clicked"
+								event-tracking-trigger="click"
+								event-tracking-mb="true"
+								event-segmentation={ page: currentUrl }
+							) #{translate('register')}
 
 					// login link
 					li
-						a(href="/login") #{translate('log_in')}
+						a(
+							href="/login"
+							event-tracking="menu-clicked-login"
+							event-tracking-action="clicked"
+							event-tracking-trigger="click"
+							event-tracking-mb="true"
+							event-segmentation={ page: currentUrl }
+						) #{translate('log_in')}
 
 				// projects link and account menu
 				if getSessionUser()

+ 16 - 2
services/web/app/views/layout/navbar.pug

@@ -88,11 +88,25 @@ nav.navbar.navbar-default.navbar-main
 					// register link
 					if hasFeature('registration-page')
 						li
-							a(href="/register") #{translate('register')}
+							a(
+								href="/register"
+								event-tracking="menu-clicked-register"
+								event-tracking-action="clicked"
+								event-tracking-trigger="click"
+								event-tracking-mb="true"
+								event-segmentation={ page: currentUrl }
+							) #{translate('register')}
 
 					// login link
 					li
-						a(href="/login") #{translate('log_in')}
+						a(
+							href="/login"
+							event-tracking="menu-clicked-login"
+							event-tracking-action="clicked"
+							event-tracking-trigger="click"
+							event-tracking-mb="true"
+							event-segmentation={ page: currentUrl }
+						) #{translate('log_in')}
 
 				// projects link and account menu
 				if getSessionUser()