| 123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475 |
- const sinon = require('sinon')
- const chai = require('chai')
- chai.should()
- const { expect } = require('chai')
- const Settings = require('settings-sharelatex')
- const docUpdaterRedis = require('@overleaf/redis-wrapper').createClient(
- Settings.redis.documentupdater
- )
- const Keys = Settings.redis.documentupdater.key_schema
- const MockTrackChangesApi = require('./helpers/MockTrackChangesApi')
- const MockProjectHistoryApi = require('./helpers/MockProjectHistoryApi')
- const MockWebApi = require('./helpers/MockWebApi')
- const DocUpdaterClient = require('./helpers/DocUpdaterClient')
- const DocUpdaterApp = require('./helpers/DocUpdaterApp')
- describe('Setting a document', function () {
- before(function (done) {
- this.lines = ['one', 'two', 'three']
- this.version = 42
- this.update = {
- doc: this.doc_id,
- op: [
- {
- i: 'one and a half\n',
- p: 4
- }
- ],
- v: this.version
- }
- this.result = ['one', 'one and a half', 'two', 'three']
- this.newLines = ['these', 'are', 'the', 'new', 'lines']
- this.source = 'dropbox'
- this.user_id = 'user-id-123'
- sinon.spy(MockTrackChangesApi, 'flushDoc')
- sinon.spy(MockProjectHistoryApi, 'flushProject')
- sinon.spy(MockWebApi, 'setDocument')
- DocUpdaterApp.ensureRunning(done)
- })
- after(function () {
- MockTrackChangesApi.flushDoc.restore()
- MockProjectHistoryApi.flushProject.restore()
- MockWebApi.setDocument.restore()
- })
- describe('when the updated doc exists in the doc updater', function () {
- before(function (done) {
- this.project_id = DocUpdaterClient.randomId()
- this.doc_id = DocUpdaterClient.randomId()
- MockWebApi.insertDoc(this.project_id, this.doc_id, {
- lines: this.lines,
- version: this.version
- })
- DocUpdaterClient.preloadDoc(this.project_id, this.doc_id, (error) => {
- if (error) {
- throw error
- }
- DocUpdaterClient.sendUpdate(
- this.project_id,
- this.doc_id,
- this.update,
- (error) => {
- if (error) {
- throw error
- }
- setTimeout(() => {
- DocUpdaterClient.setDocLines(
- this.project_id,
- this.doc_id,
- this.newLines,
- this.source,
- this.user_id,
- false,
- (error, res, body) => {
- if (error) {
- return done(error)
- }
- this.statusCode = res.statusCode
- done()
- }
- )
- }, 200)
- }
- )
- })
- })
- after(function () {
- MockTrackChangesApi.flushDoc.resetHistory()
- MockProjectHistoryApi.flushProject.resetHistory()
- MockWebApi.setDocument.resetHistory()
- })
- it('should return a 204 status code', function () {
- this.statusCode.should.equal(204)
- })
- it('should send the updated doc lines and version to the web api', function () {
- MockWebApi.setDocument
- .calledWith(this.project_id, this.doc_id, this.newLines)
- .should.equal(true)
- })
- it('should update the lines in the doc updater', function (done) {
- DocUpdaterClient.getDoc(
- this.project_id,
- this.doc_id,
- (error, res, doc) => {
- if (error) {
- return done(error)
- }
- doc.lines.should.deep.equal(this.newLines)
- done()
- }
- )
- })
- it('should bump the version in the doc updater', function (done) {
- DocUpdaterClient.getDoc(
- this.project_id,
- this.doc_id,
- (error, res, doc) => {
- if (error) {
- return done(error)
- }
- doc.version.should.equal(this.version + 2)
- done()
- }
- )
- })
- it('should leave the document in redis', function (done) {
- docUpdaterRedis.get(
- Keys.docLines({ doc_id: this.doc_id }),
- (error, lines) => {
- if (error) {
- throw error
- }
- expect(JSON.parse(lines)).to.deep.equal(this.newLines)
- done()
- }
- )
- })
- })
- describe('when the updated doc does not exist in the doc updater', function () {
- before(function (done) {
- this.project_id = DocUpdaterClient.randomId()
- this.doc_id = DocUpdaterClient.randomId()
- MockWebApi.insertDoc(this.project_id, this.doc_id, {
- lines: this.lines,
- version: this.version
- })
- DocUpdaterClient.setDocLines(
- this.project_id,
- this.doc_id,
- this.newLines,
- this.source,
- this.user_id,
- false,
- (error, res, body) => {
- if (error) {
- return done(error)
- }
- this.statusCode = res.statusCode
- setTimeout(done, 200)
- }
- )
- })
- after(function () {
- MockTrackChangesApi.flushDoc.resetHistory()
- MockProjectHistoryApi.flushProject.resetHistory()
- MockWebApi.setDocument.resetHistory()
- })
- it('should return a 204 status code', function () {
- this.statusCode.should.equal(204)
- })
- it('should send the updated doc lines to the web api', function () {
- MockWebApi.setDocument
- .calledWith(this.project_id, this.doc_id, this.newLines)
- .should.equal(true)
- })
- it('should flush track changes', function () {
- MockTrackChangesApi.flushDoc.calledWith(this.doc_id).should.equal(true)
- })
- it('should flush project history', function () {
- MockProjectHistoryApi.flushProject
- .calledWith(this.project_id)
- .should.equal(true)
- })
- it('should remove the document from redis', function (done) {
- docUpdaterRedis.get(
- Keys.docLines({ doc_id: this.doc_id }),
- (error, lines) => {
- if (error) {
- throw error
- }
- expect(lines).to.not.exist
- done()
- }
- )
- })
- })
- const DOC_TOO_LARGE_TEST_CASES = [
- {
- desc: 'when the updated doc is too large for the body parser',
- size: Settings.maxJsonRequestSize,
- expectedStatusCode: 413
- },
- {
- desc: 'when the updated doc is larger than the HTTP controller limit',
- size: Settings.max_doc_length,
- expectedStatusCode: 406
- }
- ]
- DOC_TOO_LARGE_TEST_CASES.forEach((testCase) => {
- describe(testCase.desc, function () {
- before(function (done) {
- this.project_id = DocUpdaterClient.randomId()
- this.doc_id = DocUpdaterClient.randomId()
- MockWebApi.insertDoc(this.project_id, this.doc_id, {
- lines: this.lines,
- version: this.version
- })
- this.newLines = []
- while (JSON.stringify(this.newLines).length <= testCase.size) {
- this.newLines.push('(a long line of text)'.repeat(10000))
- }
- DocUpdaterClient.setDocLines(
- this.project_id,
- this.doc_id,
- this.newLines,
- this.source,
- this.user_id,
- false,
- (error, res, body) => {
- if (error) {
- return done(error)
- }
- this.statusCode = res.statusCode
- setTimeout(done, 200)
- }
- )
- })
- after(function () {
- MockTrackChangesApi.flushDoc.resetHistory()
- MockProjectHistoryApi.flushProject.resetHistory()
- MockWebApi.setDocument.resetHistory()
- })
- it(`should return a ${testCase.expectedStatusCode} status code`, function () {
- this.statusCode.should.equal(testCase.expectedStatusCode)
- })
- it('should not send the updated doc lines to the web api', function () {
- MockWebApi.setDocument.called.should.equal(false)
- })
- it('should not flush track changes', function () {
- MockTrackChangesApi.flushDoc.called.should.equal(false)
- })
- it('should not flush project history', function () {
- MockProjectHistoryApi.flushProject.called.should.equal(false)
- })
- })
- })
- describe('when the updated doc is large but under the bodyParser and HTTPController size limit', function () {
- before(function (done) {
- this.project_id = DocUpdaterClient.randomId()
- this.doc_id = DocUpdaterClient.randomId()
- MockWebApi.insertDoc(this.project_id, this.doc_id, {
- lines: this.lines,
- version: this.version
- })
- this.newLines = []
- while (JSON.stringify(this.newLines).length < 2 * 1024 * 1024) {
- // limit in HTTPController
- this.newLines.push('(a long line of text)'.repeat(10000))
- }
- this.newLines.pop() // remove the line which took it over the limit
- DocUpdaterClient.setDocLines(
- this.project_id,
- this.doc_id,
- this.newLines,
- this.source,
- this.user_id,
- false,
- (error, res, body) => {
- if (error) {
- return done(error)
- }
- this.statusCode = res.statusCode
- setTimeout(done, 200)
- }
- )
- })
- after(function () {
- MockTrackChangesApi.flushDoc.resetHistory()
- MockProjectHistoryApi.flushProject.resetHistory()
- MockWebApi.setDocument.resetHistory()
- })
- it('should return a 204 status code', function () {
- this.statusCode.should.equal(204)
- })
- it('should send the updated doc lines to the web api', function () {
- MockWebApi.setDocument
- .calledWith(this.project_id, this.doc_id, this.newLines)
- .should.equal(true)
- })
- })
- describe('with track changes', function () {
- before(function () {
- this.lines = ['one', 'one and a half', 'two', 'three']
- this.id_seed = '587357bd35e64f6157'
- this.update = {
- doc: this.doc_id,
- op: [
- {
- d: 'one and a half\n',
- p: 4
- }
- ],
- meta: {
- tc: this.id_seed,
- user_id: this.user_id
- },
- v: this.version
- }
- })
- describe('with the undo flag', function () {
- before(function (done) {
- this.project_id = DocUpdaterClient.randomId()
- this.doc_id = DocUpdaterClient.randomId()
- MockWebApi.insertDoc(this.project_id, this.doc_id, {
- lines: this.lines,
- version: this.version
- })
- DocUpdaterClient.preloadDoc(this.project_id, this.doc_id, (error) => {
- if (error) {
- throw error
- }
- DocUpdaterClient.sendUpdate(
- this.project_id,
- this.doc_id,
- this.update,
- (error) => {
- if (error) {
- throw error
- }
- // Go back to old lines, with undo flag
- DocUpdaterClient.setDocLines(
- this.project_id,
- this.doc_id,
- this.lines,
- this.source,
- this.user_id,
- true,
- (error, res, body) => {
- if (error) {
- return done(error)
- }
- this.statusCode = res.statusCode
- setTimeout(done, 200)
- }
- )
- }
- )
- })
- })
- after(function () {
- MockTrackChangesApi.flushDoc.resetHistory()
- MockProjectHistoryApi.flushProject.resetHistory()
- MockWebApi.setDocument.resetHistory()
- })
- it('should undo the tracked changes', function (done) {
- DocUpdaterClient.getDoc(
- this.project_id,
- this.doc_id,
- (error, res, data) => {
- if (error) {
- throw error
- }
- const { ranges } = data
- expect(ranges.changes).to.be.undefined
- done()
- }
- )
- })
- })
- describe('without the undo flag', function () {
- before(function (done) {
- this.project_id = DocUpdaterClient.randomId()
- this.doc_id = DocUpdaterClient.randomId()
- MockWebApi.insertDoc(this.project_id, this.doc_id, {
- lines: this.lines,
- version: this.version
- })
- DocUpdaterClient.preloadDoc(this.project_id, this.doc_id, (error) => {
- if (error) {
- throw error
- }
- DocUpdaterClient.sendUpdate(
- this.project_id,
- this.doc_id,
- this.update,
- (error) => {
- if (error) {
- throw error
- }
- // Go back to old lines, without undo flag
- DocUpdaterClient.setDocLines(
- this.project_id,
- this.doc_id,
- this.lines,
- this.source,
- this.user_id,
- false,
- (error, res, body) => {
- if (error) {
- return done(error)
- }
- this.statusCode = res.statusCode
- setTimeout(done, 200)
- }
- )
- }
- )
- })
- })
- after(function () {
- MockTrackChangesApi.flushDoc.resetHistory()
- MockProjectHistoryApi.flushProject.resetHistory()
- MockWebApi.setDocument.resetHistory()
- })
- it('should not undo the tracked changes', function (done) {
- DocUpdaterClient.getDoc(
- this.project_id,
- this.doc_id,
- (error, res, data) => {
- if (error) {
- throw error
- }
- const { ranges } = data
- expect(ranges.changes.length).to.equal(1)
- done()
- }
- )
- })
- })
- })
- })
|