ProjectDetailsHandlerTests.coffee 13 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352
  1. should = require('chai').should()
  2. modulePath = "../../../../app/js/Features/Project/ProjectDetailsHandler"
  3. Errors = require "../../../../app/js/Features/Errors/Errors"
  4. SandboxedModule = require('sandboxed-module')
  5. sinon = require('sinon')
  6. assert = require("chai").assert
  7. expect = require("chai").expect
  8. require('chai').should()
  9. describe 'ProjectDetailsHandler', ->
  10. beforeEach ->
  11. @project_id = "321l3j1kjkjl"
  12. @user_id = "user-id-123"
  13. @project =
  14. name: "project"
  15. description: "this is a great project"
  16. something:"should not exist"
  17. compiler: "latexxxxxx"
  18. owner_ref: @user_id
  19. @user =
  20. features: "mock-features"
  21. @ProjectGetter =
  22. getProjectWithoutDocLines: sinon.stub().callsArgWith(1, null, @project)
  23. getProject: sinon.stub().callsArgWith(2, null, @project)
  24. @ProjectModel =
  25. update: sinon.stub()
  26. findOne: sinon.stub()
  27. @UserGetter =
  28. getUser: sinon.stub().callsArgWith(1, null, @user)
  29. @tpdsUpdateSender =
  30. moveEntity:sinon.stub().callsArgWith 1
  31. @handler = SandboxedModule.require modulePath, requires:
  32. "./ProjectGetter":@ProjectGetter
  33. '../../models/Project': Project:@ProjectModel
  34. "../User/UserGetter": @UserGetter
  35. '../ThirdPartyDataStore/TpdsUpdateSender':@tpdsUpdateSender
  36. 'logger-sharelatex':
  37. log:->
  38. err:->
  39. './ProjectTokenGenerator': @ProjectTokenGenerator = {}
  40. 'settings-sharelatex': @settings =
  41. defaultFeatures: 'default-features'
  42. describe "getDetails", ->
  43. it "should find the project and owner", (done)->
  44. @handler.getDetails @project_id, (err, details)=>
  45. details.name.should.equal @project.name
  46. details.description.should.equal @project.description
  47. details.compiler.should.equal @project.compiler
  48. details.features.should.equal @user.features
  49. assert.equal(details.something, undefined)
  50. done()
  51. it "should find overleaf metadata if it exists", (done)->
  52. @project.overleaf = { id: 'id' }
  53. @handler.getDetails @project_id, (err, details)=>
  54. details.overleaf.should.equal @project.overleaf
  55. assert.equal(details.something, undefined)
  56. done()
  57. it "should return an error for a non-existent project", (done)->
  58. @ProjectGetter.getProject.callsArg(2, null, null)
  59. err = new Errors.NotFoundError("project not found")
  60. @handler.getDetails "0123456789012345678901234", (error, details) =>
  61. err.should.eql error
  62. done()
  63. it 'should return the default features if no owner found', (done) ->
  64. @UserGetter.getUser.callsArgWith(1, null, null)
  65. @handler.getDetails @project_id, (err, details)=>
  66. details.features.should.equal @settings.defaultFeatures
  67. done()
  68. it "should return the error", (done)->
  69. error = "some error"
  70. @ProjectGetter.getProject.callsArgWith(2, error)
  71. @handler.getDetails @project_id, (err)=>
  72. err.should.equal error
  73. done()
  74. describe "getProjectDescription", ->
  75. it "should make a call to mongo just for the description", (done)->
  76. @ProjectGetter.getProject.callsArgWith(2)
  77. @handler.getProjectDescription @project_id, (err, description)=>
  78. @ProjectGetter.getProject
  79. .calledWith(@project_id, description: true)
  80. .should.equal true
  81. done()
  82. it "should return what the mongo call returns", (done)->
  83. err = "error"
  84. description = "cool project"
  85. @ProjectGetter.getProject.callsArgWith(2, err, {description:description})
  86. @handler.getProjectDescription @project_id, (returnedErr, returnedDescription)=>
  87. err.should.equal returnedErr
  88. description.should.equal returnedDescription
  89. done()
  90. describe "setProjectDescription", ->
  91. beforeEach ->
  92. @description = "updated teh description"
  93. it "should update the project detials", (done)->
  94. @ProjectModel.update.callsArgWith(2)
  95. @handler.setProjectDescription @project_id, @description, =>
  96. @ProjectModel.update.calledWith({_id:@project_id}, {description:@description}).should.equal true
  97. done()
  98. describe "renameProject", ->
  99. beforeEach ->
  100. @handler.validateProjectName = sinon.stub().yields()
  101. @ProjectModel.update.callsArgWith(2)
  102. @newName = "new name here"
  103. it "should update the project with the new name", (done)->
  104. newName = "new name here"
  105. @handler.renameProject @project_id, @newName, =>
  106. @ProjectModel.update.calledWith({_id: @project_id}, {name: @newName}).should.equal true
  107. done()
  108. it "should tell the tpdsUpdateSender", (done)->
  109. @handler.renameProject @project_id, @newName, =>
  110. @tpdsUpdateSender.moveEntity.calledWith({project_id:@project_id, project_name:@project.name, newProjectName:@newName}).should.equal true
  111. done()
  112. it "should not do anything with an invalid name", (done) ->
  113. @handler.validateProjectName = sinon.stub().yields(new Error("invalid name"))
  114. @handler.renameProject @project_id, @newName, =>
  115. @tpdsUpdateSender.moveEntity.called.should.equal false
  116. @ProjectModel.update.called.should.equal false
  117. done()
  118. describe "validateProjectName", ->
  119. it "should reject undefined names", (done) ->
  120. @handler.validateProjectName undefined, (error) ->
  121. expect(error).to.exist
  122. done()
  123. it "should reject empty names", (done) ->
  124. @handler.validateProjectName "", (error) ->
  125. expect(error).to.exist
  126. done()
  127. it "should reject names with /s", (done) ->
  128. @handler.validateProjectName "foo/bar", (error) ->
  129. expect(error).to.exist
  130. done()
  131. it "should reject names with \\s", (done) ->
  132. @handler.validateProjectName "foo\\bar", (error) ->
  133. expect(error).to.exist
  134. done()
  135. it "should reject long names", (done) ->
  136. @handler.validateProjectName new Array(1000).join("a"), (error) ->
  137. expect(error).to.exist
  138. done()
  139. it "should accept normal names", (done) ->
  140. @handler.validateProjectName "foobar", (error) ->
  141. expect(error).to.not.exist
  142. done()
  143. describe "ensureProjectNameIsUnique", ->
  144. beforeEach ->
  145. @result = {
  146. owned: [{_id: 1, name:"name"}, {_id: 2, name: "name1"}, {_id: 3, name: "name11"}, {_id: 100, name: "numeric"}]
  147. readAndWrite: [{_id: 4, name:"name2"}, {_id: 5, name:"name22"}]
  148. readOnly: [{_id:6, name:"name3"}, {_id:7, name: "name33"}]
  149. tokenReadAndWrite: [{_id:8, name:"name4"}, {_id:9, name:"name44"}]
  150. tokenReadOnly: [{_id:10, name:"name5"}, {_id:11, name:"name55"}, {_id:12, name:"x".repeat(15)}]
  151. }
  152. for i in [1..20].concat([30..40])
  153. @result.owned.push {_id: 100 + i, name: "numeric (#{i})"}
  154. @ProjectGetter.findAllUsersProjects = sinon.stub().callsArgWith(2, null, @result)
  155. it "should leave a unique name unchanged", (done) ->
  156. @handler.ensureProjectNameIsUnique @user_id, "unique-name", ["-test-suffix"], (error, name, changed) ->
  157. expect(name).to.equal "unique-name"
  158. expect(changed).to.equal false
  159. done()
  160. it "should append a suffix to an existing name", (done) ->
  161. @handler.ensureProjectNameIsUnique @user_id, "name1", ["-test-suffix"], (error, name, changed) ->
  162. expect(name).to.equal "name1-test-suffix"
  163. expect(changed).to.equal true
  164. done()
  165. it "should fallback to a second suffix when needed", (done) ->
  166. @handler.ensureProjectNameIsUnique @user_id, "name1", ["1", "-test-suffix"], (error, name, changed) ->
  167. expect(name).to.equal "name1-test-suffix"
  168. expect(changed).to.equal true
  169. done()
  170. it "should truncate the name when append a suffix if the result is too long", (done) ->
  171. @handler.MAX_PROJECT_NAME_LENGTH = 20
  172. @handler.ensureProjectNameIsUnique @user_id, "x".repeat(15), ["-test-suffix"], (error, name, changed) ->
  173. expect(name).to.equal "x".repeat(8) + "-test-suffix"
  174. expect(changed).to.equal true
  175. done()
  176. it "should use a numeric index if no suffix is supplied", (done) ->
  177. @handler.ensureProjectNameIsUnique @user_id, "name1", [], (error, name, changed) ->
  178. expect(name).to.equal "name1 (1)"
  179. expect(changed).to.equal true
  180. done()
  181. it "should use a numeric index if all suffixes are exhausted", (done) ->
  182. @handler.ensureProjectNameIsUnique @user_id, "name", ["1", "11"], (error, name, changed) ->
  183. expect(name).to.equal "name (1)"
  184. expect(changed).to.equal true
  185. done()
  186. it "should find the next lowest available numeric index for the base name", (done) ->
  187. @handler.ensureProjectNameIsUnique @user_id, "numeric", [], (error, name, changed) ->
  188. expect(name).to.equal "numeric (21)"
  189. expect(changed).to.equal true
  190. done()
  191. it "should find the next available numeric index when a numeric index is already present", (done) ->
  192. @handler.ensureProjectNameIsUnique @user_id, "numeric (5)", [], (error, name, changed) ->
  193. expect(name).to.equal "numeric (21)"
  194. expect(changed).to.equal true
  195. done()
  196. it "should not find a numeric index lower than the one already present", (done) ->
  197. @handler.ensureProjectNameIsUnique @user_id, "numeric (31)", [], (error, name, changed) ->
  198. expect(name).to.equal "numeric (41)"
  199. expect(changed).to.equal true
  200. done()
  201. describe "fixProjectName", ->
  202. it "should change empty names to Untitled", () ->
  203. expect(@handler.fixProjectName "").to.equal "Untitled"
  204. it "should replace / with -", () ->
  205. expect(@handler.fixProjectName "foo/bar").to.equal "foo-bar"
  206. it "should replace \\ with ''", () ->
  207. expect(@handler.fixProjectName "foo \\ bar").to.equal "foo bar"
  208. it "should truncate long names", () ->
  209. expect(@handler.fixProjectName new Array(1000).join("a")).to.equal "a".repeat(150)
  210. it "should accept normal names", () ->
  211. expect(@handler.fixProjectName "foobar").to.equal "foobar"
  212. describe "setPublicAccessLevel", ->
  213. beforeEach ->
  214. @ProjectModel.update.callsArgWith(2)
  215. @accessLevel = "readOnly"
  216. it "should update the project with the new level", (done)->
  217. @handler.setPublicAccessLevel @project_id, @accessLevel, =>
  218. @ProjectModel.update.calledWith({_id: @project_id}, {publicAccesLevel: @accessLevel}).should.equal true
  219. done()
  220. it 'should not produce an error', (done) ->
  221. @handler.setPublicAccessLevel @project_id, @accessLevel, (err) =>
  222. expect(err).to.not.exist
  223. done()
  224. describe 'when update produces an error', ->
  225. beforeEach ->
  226. @ProjectModel.update.callsArgWith(2, new Error('woops'))
  227. it 'should produce an error', (done) ->
  228. @handler.setPublicAccessLevel @project_id, @accessLevel, (err) =>
  229. expect(err).to.exist
  230. expect(err).to.be.instanceof Error
  231. done()
  232. describe "ensureTokensArePresent", ->
  233. beforeEach ->
  234. describe 'when the project has tokens', ->
  235. beforeEach ->
  236. @project =
  237. _id: @project_id
  238. tokens:
  239. readOnly: 'aaa'
  240. readAndWrite: '42bbb'
  241. @ProjectGetter.getProject = sinon.stub()
  242. .callsArgWith(2, null, @project)
  243. @ProjectModel.update = sinon.stub()
  244. it 'should get the project', (done) ->
  245. @handler.ensureTokensArePresent @project_id, (err, tokens) =>
  246. expect(@ProjectGetter.getProject.callCount).to.equal 1
  247. expect(@ProjectGetter.getProject.calledWith(@project_id, {tokens: 1}))
  248. .to.equal true
  249. done()
  250. it 'should not update the project with new tokens', (done) ->
  251. @handler.ensureTokensArePresent @project_id, (err, tokens) =>
  252. expect(@ProjectModel.update.callCount).to.equal 0
  253. done()
  254. it 'should produce the tokens without error', (done) ->
  255. @handler.ensureTokensArePresent @project_id, (err, tokens) =>
  256. expect(err).to.not.exist
  257. expect(tokens).to.deep.equal @project.tokens
  258. done()
  259. describe 'when tokens are missing', ->
  260. beforeEach ->
  261. @project =
  262. _id: @project_id
  263. @ProjectGetter.getProject = sinon.stub()
  264. .callsArgWith(2, null, @project)
  265. @readOnlyToken = 'abc'
  266. @readAndWriteToken = '42def'
  267. @ProjectTokenGenerator.generateUniqueReadOnlyToken = sinon.stub().callsArgWith(0, null, @readOnlyToken)
  268. @ProjectTokenGenerator.readAndWriteToken = sinon.stub().returns(@readAndWriteToken)
  269. @ProjectModel.update = sinon.stub()
  270. .callsArgWith(2, null)
  271. it 'should get the project', (done) ->
  272. @handler.ensureTokensArePresent @project_id, (err, tokens) =>
  273. expect(@ProjectGetter.getProject.callCount).to.equal 1
  274. expect(@ProjectGetter.getProject.calledWith(@project_id, {tokens: 1}))
  275. .to.equal true
  276. done()
  277. it 'should update the project with new tokens', (done) ->
  278. @handler.ensureTokensArePresent @project_id, (err, tokens) =>
  279. expect(@ProjectTokenGenerator.generateUniqueReadOnlyToken.callCount)
  280. .to.equal 1
  281. expect(@ProjectTokenGenerator.readAndWriteToken.callCount)
  282. .to.equal 1
  283. expect(@ProjectModel.update.callCount).to.equal 1
  284. expect(@ProjectModel.update.calledWith(
  285. {_id: @project_id},
  286. {$set: {tokens: {readOnly: @readOnlyToken, readAndWrite: @readAndWriteToken}}}
  287. )).to.equal true
  288. done()
  289. it 'should produce the tokens without error', (done) ->
  290. @handler.ensureTokensArePresent @project_id, (err, tokens) =>
  291. expect(err).to.not.exist
  292. expect(tokens).to.deep.equal {
  293. readOnly: @readOnlyToken,
  294. readAndWrite: @readAndWriteToken
  295. }
  296. done()