pr_19612.patch 2.2 KB

12345678910111213141516171819202122232425262728293031323334353637383940414243444546
  1. diff --git a/services/web/app/src/Features/HealthCheck/HealthCheckController.js b/services/web/app/src/Features/HealthCheck/HealthCheckController.js
  2. index 278f04bb767..ff074cfa816 100644
  3. --- a/services/web/app/src/Features/HealthCheck/HealthCheckController.js
  4. +++ b/services/web/app/src/Features/HealthCheck/HealthCheckController.js
  5. @@ -45,6 +45,10 @@ module.exports = {
  6. logger.err({ err }, 'failed api redis health check')
  7. return res.sendStatus(500)
  8. }
  9. + if (!settings.smokeTest.userId) {
  10. + logger.err({}, 'smokeTest.userId is undefined in health check')
  11. + return res.sendStatus(404)
  12. + }
  13. UserGetter.getUserEmail(settings.smokeTest.userId, (err, email) => {
  14. if (err) {
  15. logger.err({ err }, 'failed api mongo health check')
  16. diff --git a/services/web/app/src/infrastructure/ExpressLocals.js b/services/web/app/src/infrastructure/ExpressLocals.js
  17. index 5f14977d3a3..2e9ed4f1ebb 100644
  18. --- a/services/web/app/src/infrastructure/ExpressLocals.js
  19. +++ b/services/web/app/src/infrastructure/ExpressLocals.js
  20. @@ -11,6 +11,7 @@ const Features = require('./Features')
  21. const SessionManager = require('../Features/Authentication/SessionManager')
  22. const PackageVersions = require('./PackageVersions')
  23. const Modules = require('./Modules')
  24. +const Errors = require('../Features/Errors/Errors')
  25. const {
  26. canRedirectToAdminDomain,
  27. hasAdminAccess,
  28. @@ -236,10 +237,14 @@ module.exports = function (webRouter, privateApiRouter, publicApiRouter) {
  29. // Don't include the query string parameters, otherwise Google
  30. // treats ?nocdn=true as the canonical version
  31. - const parsedOriginalUrl = new URL(req.originalUrl, Settings.siteUrl)
  32. - res.locals.currentUrl = parsedOriginalUrl.pathname
  33. - res.locals.currentUrlWithQueryParams =
  34. - parsedOriginalUrl.pathname + parsedOriginalUrl.search
  35. + try {
  36. + const parsedOriginalUrl = new URL(req.originalUrl, Settings.siteUrl)
  37. + res.locals.currentUrl = parsedOriginalUrl.pathname
  38. + res.locals.currentUrlWithQueryParams =
  39. + parsedOriginalUrl.pathname + parsedOriginalUrl.search
  40. + } catch (err) {
  41. + return next(new Errors.InvalidError())
  42. + }
  43. res.locals.capitalize = function (string) {
  44. if (string.length === 0) {
  45. return ''