pr_27273.patch 3.8 KB

12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849505152535455565758596061626364656667686970717273747576777879808182
  1. diff --git a/services/web/frontend/js/features/review-panel-new/components/review-tooltip-menu.tsx b/services/web/frontend/js/features/review-panel-new/components/review-tooltip-menu.tsx
  2. index f26542ebe909..fb6b68460bdc 100644
  3. --- a/services/web/frontend/js/features/review-panel-new/components/review-tooltip-menu.tsx
  4. +++ b/services/web/frontend/js/features/review-panel-new/components/review-tooltip-menu.tsx
  5. @@ -18,7 +18,6 @@ import {
  6. reviewTooltipStateField,
  7. } from '@/features/source-editor/extensions/review-tooltip'
  8. import { EditorView, getTooltip } from '@codemirror/view'
  9. -import useViewerPermissions from '@/shared/hooks/use-viewer-permissions'
  10. import usePreviousValue from '@/shared/hooks/use-previous-value'
  11. import { useLayoutContext } from '@/shared/context/layout-context'
  12. import { useReviewPanelViewActionsContext } from '../context/review-panel-view-context'
  13. @@ -35,6 +34,7 @@ import { useEditorPropertiesContext } from '@/features/ide-react/context/editor-
  14. import classNames from 'classnames'
  15. import useEventListener from '@/shared/hooks/use-event-listener'
  16. import useReviewPanelLayout from '../hooks/use-review-panel-layout'
  17. +import { usePermissionsContext } from '@/features/ide-react/context/permissions-context'
  18. const EDIT_MODE_SWITCH_WIDGET_HEIGHT = 40
  19. const CM_LINE_RIGHT_PADDING = 8
  20. @@ -43,7 +43,7 @@ const TOOLTIP_SHOW_DELAY = 120
  21. const ReviewTooltipMenu: FC = () => {
  22. const state = useCodeMirrorStateContext()
  23. const view = useCodeMirrorViewContext()
  24. - const isViewer = useViewerPermissions()
  25. + const permissions = usePermissionsContext()
  26. const [show, setShow] = useState(true)
  27. const { setView } = useReviewPanelViewActionsContext()
  28. const { openReviewPanel } = useReviewPanelLayout()
  29. @@ -58,7 +58,7 @@ const ReviewTooltipMenu: FC = () => {
  30. const addComment = useCallback(() => {
  31. const { main } = view.state.selection
  32. - if (main.empty) {
  33. + if (main.empty || !permissions.comment) {
  34. return
  35. }
  36. @@ -74,11 +74,11 @@ const ReviewTooltipMenu: FC = () => {
  37. view.dispatch({ effects })
  38. setShow(false)
  39. - }, [openReviewPanel, setView, setShow, view])
  40. + }, [view, permissions.comment, openReviewPanel, setView])
  41. useEventListener('add-new-review-comment', addComment)
  42. - if (isViewer || !show || !tooltipState) {
  43. + if (!permissions.comment || !show || !tooltipState) {
  44. return null
  45. }
  46. diff --git a/services/web/frontend/js/features/source-editor/components/toolbar/toolbar-items.tsx b/services/web/frontend/js/features/source-editor/components/toolbar/toolbar-items.tsx
  47. index 3404976d4462..1811ccc99950 100644
  48. --- a/services/web/frontend/js/features/source-editor/components/toolbar/toolbar-items.tsx
  49. +++ b/services/web/frontend/js/features/source-editor/components/toolbar/toolbar-items.tsx
  50. @@ -16,5 +16,6 @@ import { isSplitTestEnabled } from '@/utils/splitTestUtils'
  51. import { isMac } from '@/shared/utils/os'
  52. import { useProjectContext } from '@/shared/context/project-context'
  53. +import { usePermissionsContext } from '@/features/ide-react/context/permissions-context'
  54. export const ToolbarItems: FC<{
  55. state: EditorState
  56. @@ -35,6 +36,7 @@ export const ToolbarItems: FC<{
  57. useEditorPropertiesContext()
  58. const { writefullInstance } = useEditorContext()
  59. const { features } = useProjectContext()
  60. + const permissions = usePermissionsContext()
  61. const isActive = withinFormattingCommand(state)
  62. const symbolPaletteAvailable = getMeta('ol-symbolPaletteAvailable')
  63. @@ -131,7 +133,7 @@ export const ToolbarItems: FC<{
  64. command={commands.wrapInHref}
  65. icon="add_link"
  66. />
  67. - {features.trackChangesVisible && (
  68. + {features.trackChangesVisible && permissions.comment && (
  69. <ToolbarButton
  70. id="toolbar-add-comment"
  71. label={t('add_comment')}